Review: Needs Fixing

there are some improvements related to the flow:

you don't need to find related internal picking by the name of MO, 
there is already a m2o field picking_id for related picking in MO, can't you 
use that?

I don't really understand the flow of test cases in yml, 
in mrp/test/mrp_production_order.yml, check the case of mrp_production_mo1, 
    you make it cancelled from ready, and then change the qty and then make it 
done.
    while in real there is no such case and provision to change qty and to make 
it done form cancelled MO.
    (also check the active_ids passed in context for step "Changes the Quantity 
of Product.")

mrp_repair/test/test_mrp_repair.yml: 89: ".. Button For Invoice Type b4repair", 
I saw the invoice type is after_repair in that order

mrp_repair/test/test_mrp_repair.yml: last case is wrong, repair order can't be 
cancelled after done

mrp_repair/test/mrp_repair_cancel.yml: mrp_repair_rma1 is having invoice type 
before repair so from confirmed you can start repair only after making invoice

thanks
-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-mrp-coverage-new-ksa/+merge/76212
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openobject-addons/trunk-mrp-coverage-new-ksa.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to