Review: Needs Fixing

* The normal name of qweb templates on widgets is `template` (see 
openerp.web.Widget)
  Ideally, the mobile client would be altered to use the "normal" Widget usage 
flow, which would take care of rendering `this.template` without an explicit 
call to `this.render` (also keep coherent names, in Menu, Shortcuts and 
Menu.secondary you called the template `qweb_template_name`, but in the 
ListView you called it `list_view_template`, why?)
* Why do you setup a new `ListViewClass` attribute? Why not just replace the 
`openerp.web_mobile.ListView` class in your own addon?
* Why is the main sub-template of the Form view called `FormContent`, but the 
one in the List view called ViewContent?
  - and incidentally, what is the reason for those splits of templates?
-- 
https://code.launchpad.net/~vaab/openerp-web/mobile-client-extendability-patch/+merge/76583
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openerp-web/mobile-client.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to