Review: Disapprove

I don't see how that could work: format_value is a synchronous function, it's 
supposed to return a result not provide one through callback, and here the 
`reference` case does not (and can not) return anything. Instead it performs an 
RPC calls which just loses its value in the ether.

Not only that, but from what I know the value of a `reference` field is a 
string, you don't perform any conversion so you end up with `id :: String`, 
which is just going to blow up when it reaches the server.
-- 
https://code.launchpad.net/~openerp-dev/openerp-web/trunk-bug-861434-vda/+merge/78217
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openerp-web/trunk-bug-861434-vda.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to