Review: Needs Fixing 1. No need to use isString, the value should be either falsy or a correct string, just check for truthiness.
2. No need to use _.size (especially as it's a duplication of Array.prototype.length). 3. *Always* provide the base to parseInt, otherwise it is *not* going to work correctly if the id part is e.g. `015` (which will be interpreted as an octal) Otherwise looks good code-wise, do you have a model/action where this can be tested? -- https://code.launchpad.net/~openerp-dev/openerp-web/trunk-bug-861434-vda/+merge/79650 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openerp-web/trunk-bug-861434-vda. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
