Review: Needs Fixing 1. Indentation is all fucked up and there are semi-spurious whitespace changes, please revert them. Not that cleaning up whitespace is not a good thing, but not as part of a merge proposal for a fix.
2. Why do you add a `this.readonly` check in `check_disable` method? Are there views/conditions under which buttons can be set readonly and still be visible? I think that should be in a different proposal anyway, it's got nothing to do with action contexts 3. Fix is not correct, you can't just go crash through the shared dataset context like that, a better way would probably be to copy the node attrs (as the action descriptors) and replace its context with a CompoundContext on which you'll set the form content (`this.view.datarecord`) as an evaluation context. -- https://code.launchpad.net/~openerp-dev/openerp-web/trunk-bug-862138-hpa/+merge/78932 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openerp-web/trunk-bug-862138-hpa. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
