Review: Disapprove

- _.extend(this.view.dataset.context, ...) -> This is not a correct way to 
extend a context, you have to use CompoundContext for that
- Altering the dataset's context is not allowed
- Using simply this.view.datatarecord is a naive way of getting the values of 
the fields and is not sufficient.
- You're not supposed to put those values in an existing context, they must be 
in the evaluation context of the context, not in the context itself.
-- 
https://code.launchpad.net/~openerp-dev/openerp-web/trunk-bug-862138-hpa/+merge/78932
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openerp-web/trunk-bug-862138-hpa.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to