Review: Needs Fixing

If add a call to _super(), this proxies up to Field#set_value which sets 
invalid to false and calls #update_dom and #on_value_changed. Shouldn't these 
then be removed from FieldMany2OneReadonly#set_value?

Also tmp_value seems redundant, I'm guessing I copy/pasted it from 
FieldMany2One#set_value without giving it much thought, but there does not seem 
to be any point to it in Readonly version.
-- 
https://code.launchpad.net/~openerp-dev/openerp-web/trunk-bug-878033-ysa/+merge/79809
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openerp-web/trunk-bug-878033-ysa.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to