Review: Resubmit > If add a call to _super(), this proxies up to Field#set_value which sets > invalid to false and calls #update_dom and #on_value_changed. Shouldn't these > then be removed from FieldMany2OneReadonly#set_value? I remove call of _super() from FieldMany2OneReadonly#set_value. > Also tmp_value seems redundant, I'm guessing I copy/pasted it from > FieldMany2One#set_value without giving it much thought, but there does not > seem to be any point to it in Readonly version. Set the value in this.value because FieldMany2One define get_value method and in this method check if this.tmp_value have a value then return this.tmp_value but in FieldMany2OneReadonly not define get_value method so it always return the this.value. so i remove the this.tmp_value and set value in this.value. -- https://code.launchpad.net/~openerp-dev/openerp-web/trunk-bug-878033-ysa/+merge/79809 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openerp-web/trunk-bug-878033-ysa.
_______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
