Review: Needs Fixing Hi Naresh,
i've tested but i found a problem (Not sure i didn't break it myself during the merge, though): *given you have an audittrail rule for res.partner and res.partner.address *given you have a partner Agrolait with 4 existing addresses *if you create a new address for this partner, it will create you the following logs - one write on contatcs fields of res.partner (correct) - four empty writes on res.partner.address where no changes are logged (not correct) - one write on res.partner.address with the data you just created (incorrect, the method logged should be 'create' instead of 'write', otherwise it's ok) i've commited in your branch my merge with trunk, not to loose my work. You should starts from it. Also, let me know if i need to assign someone else on this task, as i'm not aware of your current load (but as you made this merge prop you'll probably be faster than anyone for it ;-) ). Btw, i'm setting this merge prop as 'work in progress' so that it's not anymore on the pending merge we need to review. Reset its state back to 'needs review' when you're work is over. Thanks, Quentin -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-832635-nch/+merge/77861 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-832635-nch. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
