Review: Needs Fixing hi again Naresh,
before proceeding, i still have few remarks: 1) in the docstring of get_value_text() please add the meaning of the params and returned value 2) please document the function start_log_process() 3) the code of inline_process_old_data() and inline_process_new_data() seems really similar. I wonder if we couldn't factorize that code. Morover, having those functions inside another function make the code a bit unreadable. 4) a general effort of documenting/commenting is needed because the code is really difficult to understand. Next time will be the good one, i'm pretty sure of it! (otherwise, the bug is totally fixed by now and the module seems to run perfectly!) Regards, Quentin -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-832635-nch/+merge/77861 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-832635-nch. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
