> just few comments: > 1) can you make a new function to retrieve the dict to use to create the > invoice line, > _prepare_invoice_line_data(), in order to increase the inheritability and > flexibility of our code
I can not make a new function as inv_line_create function is used in other modules too, and might be used somewhere else in other community modules. I just changed signature of inv_line_create to return dict of data and this will be less risky as it requires less changes in overridden method. => o_O geez.. no you're wrong changing the signature is the same as it break the API too, maybe even worst as it may silent errors in some cases. Thus changing the name makes it more clear and that the good opportunity do to it. >And as a bonus I changed stupid variable names a, o, il .. >this will cost you more to review but will be better, what do you think? => that's an excelent idea great work, i merged after changing the name of function -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-724131-rpa/+merge/82254 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-724131-rpa. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
