Review: Needs Fixing

Mucking three levels deep in the internal state of compound contexts is not 
acceptable, and it's even less so in that it's not correct (the context section 
may be non-literal, or you may be missing other context sections).

The proper way to get a usable context is to evaluate it via the 
eval_domain_and_context RPC call (see line 2607). This *may* require other 
changes as SelectCreatePopup's startup phase does not seem completely fit for 
asynchronous initialization.

Also, indentation and code formatting are not correct and don't follow rest of 
codebase: indentation is 4 spaces (not 8) and indentation style is 1TBS, not 
Allman.
-- 
https://code.launchpad.net/~openerp-dev/openerp-web/trunk-polish3-search-m2o-field-tta/+merge/83000
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openerp-web/trunk-polish3-search-m2o-field-tta.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to