Review: Needs Fixing
* Could you move the creation of the `search_defaults` variable inside the
anonymous function you created? (right before the `_.each` call)
* Also don't forget to declare variables with `var` e.g. `var search_defaults =
{}`, otherwise it creates a global variable which is *not* good.
* Finally, no need to sign your commits with [tta], the commit metadata
includes who you are. Commits should only be marked with [ADD] (add new
feature), [FIX] (fix a bug), [IMP] (improves the code), [REM] (removes stuff)
or [REF] (refactors existing code)
--
https://code.launchpad.net/~openerp-dev/openerp-web/trunk-polish3-search-m2o-field-tta/+merge/83000
Your team OpenERP R&D Team is subscribed to branch
lp:~openerp-dev/openerp-web/trunk-polish3-search-m2o-field-tta.
_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help : https://help.launchpad.net/ListHelp
