> * Don't use ids > * Don't use inline styles, especially not when they're redundant (e.g. a > `width 100%` on a div, div elements do that by default) > * Play on classes for style and display manipulations when possible (it's very > possible for this code) > * Don't repeatedly select the same element over and over in the same code > block, either memoize it or use chains > * Why do you call `status` twice on `publisher_warranty.contract`, is there > really a chance users may have lost their contract between the popup and their > decision to send the traceback? > * Why do you create search datasets when you don't have any search to perform, > why not a regular dataset? > * ServerError seems to be a dialog, is there a reason why it does not inherit > from Dialog? > * You have inserted a number of whitespace changes in code you have not > modified, that's bad. > * Beware the coding style, parameter-separating commas should be followed by a > space, and so should the parens of a block (e.g. function definition) > * The `parent` of a widget should be an other widget, the way ServerError is > initialized is broken (you initialize it with some random object received from > the server). `this.parent` is used to link UI objects with one another, not to > shove random stuff in. > * Don't use tables to layout paragraphs.
Hello, Implement the server exception dialog box, covering the 2 cases (with/without a contract). If There is a contract, then have to validate based on status of contract. If status of contract is full then contract is valid else if status is none then it is invalid. If Contract is valid then open the form of Publisher Warranty Contract issue and send mail with the details of issue to the publisher warranty team. If contract is invalid then open the link http://www.openerp.com/support-or-publisher-warranty-contract in new tab. Code is modify as per your suggestions. Thanks & Regards, Bhumi Thakkar -- https://code.launchpad.net/~openerp-dev/openerp-web/server-exception-bth/+merge/83368 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openerp-web/server-exception-bth. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
