Review: Needs Fixing
* $cur_ele is an implicit global variable (its naming is also pretty terrible)
* because $cur_ele is not used consistently, some references are woefully
incorrect (e.g. `$(this)` line 215 is within the dataset's callback, and
therefore going to wrap `window` in $)
* Traversals (e.g. chains of `$(this).next().toggle().prev()`,
`$cur_ele.find('a')`) should also be memoized, there is no justification for
duplicating them so.
* As noted previously, please do not use hardcoded identifiers.
* And please manipulate styles via classes where possible, I don't believe line
205 should be done via CSS.
--
https://code.launchpad.net/~openerp-dev/openerp-web/server-exception-bth/+merge/83368
Your team OpenERP R&D Team is subscribed to branch
lp:~openerp-dev/openerp-web/server-exception-bth.
_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help : https://help.launchpad.net/ListHelp
