Review: Disapprove
Although the condition may not be correct in that button (not too sure), I
don't see the relation with the bug. And it does not work either, did you test
it? Take an existing menu (e.g. Leads), edit the corresponding menu action to
remove the "form" view from the listing (in view_mode *and* view_ids, if need
be) then try to click on "Create" or on a row.
Both with and without this patch, you will be able to and will get a message
`TypeError: 'undefined' is not an object (evaluating 'view.controller')` in the
javascript console (and it's not like the patch could fix the issue of clicking
on a record in the list view, since it *only* affects the creation button)
Issue here is that list view asks to switch to page view (by calling
`View#do_switch_view('page')`, which ViewManager proxies to
`ViewManager#on_mode_switch('page')`), and `ViewManager#on_mode_switch` does
not verify that view type it receives is valid (is available in its `views`
dict). As a result it tries to switch to `undefined` which blows up, and
ActionManager gets into an invalid state.
I am rejecting this merge proposal, please submit a fix which fixes the actual
issue.
--
https://code.launchpad.net/~openerp-dev/openerp-web/trunk-bug-900805-vme/+merge/84721
Your team OpenERP R&D Team is subscribed to branch
lp:~openerp-dev/openerp-web/trunk-bug-900805-vme.
_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help : https://help.launchpad.net/ListHelp
