Review: Needs Fixing

* Please revert the button part, it does not belong here
* You can perform a direct containment test (`in` operator) on the `views` 
object, no need to use `views_src`, include, pluck, etc…
* This should be in the ViewManager as it can be needed in the viewmanager as 
well
* And in any case the method should return a "failed" (rejected) deferred in 
order to ensure callers do not execute post-switch code
-- 
https://code.launchpad.net/~openerp-dev/openerp-web/trunk-bug-900805-vme/+merge/84754
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openerp-web/trunk-bug-900805-vme.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to