Review: Needs Fixing

I don't know if it's the right way to fix this because I think that get_value() 
on fields should return the good value wathever the case (eg: false if invalid, 
...). I'll discuss about this with niv because I'm not sure about relation 
fields.

Anyway, this is not correct :

values[key] = val || false;

because you will set a false value even if the field has a legitimate value 
such as an empty string or a zero.

-- 
https://code.launchpad.net/~openerp-dev/openerp-web/trunk-bug-896909-vme/+merge/84068
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openerp-web/trunk-bug-896909-vme.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to