Vidhin Mehta (OpenERP) has proposed merging
lp:~openerp-dev/openerp-web/trunk-bug-896909-vme into lp:openerp-web.
Requested reviews:
OpenERP R&D Web Team (openerp-dev-web)
Related bugs:
Bug #896909 in OpenERP Web: "sale order line: 'product_uom_qty' is not
defined"
https://bugs.launchpad.net/openerp-web/+bug/896909
For more details, see:
https://code.launchpad.net/~openerp-dev/openerp-web/trunk-bug-896909-vme/+merge/85834
Hello,
"sale order line: 'product_uom_qty' is not defined" in this issue,
get_fields_values can't be called after all initialised because it is
called from set_value() of many2one widget and
other side many widget's get_value method not returning false if value
is undefined.
So in this patch it returns appropriate value.
Thanks.
--
https://code.launchpad.net/~openerp-dev/openerp-web/trunk-bug-896909-vme/+merge/85834
Your team OpenERP R&D Team is subscribed to branch
lp:~openerp-dev/openerp-web/trunk-bug-896909-vme.
=== modified file 'addons/web/static/src/js/view_form.js'
--- addons/web/static/src/js/view_form.js 2011-12-15 10:40:31 +0000
+++ addons/web/static/src/js/view_form.js 2011-12-15 11:14:54 +0000
@@ -519,8 +519,8 @@
_.each(this.fields, function(value, key) {
var val = value.get_value();
values[key] = val;
- });
- return values;
+ });
+ return values;
},
get_selected_ids: function() {
var id = this.dataset.ids[this.dataset.index];
@@ -1204,7 +1204,7 @@
this.view.open_translate_dialog(this);
},
get_value: function() {
- return this.value;
+ return this.value || false;
},
is_valid: function() {
return !this.invalid;
@@ -1383,7 +1383,7 @@
this.$input.val(value ? this.format_client(value) : '');
},
get_value: function() {
- return this.value;
+ return this.value || false;
},
set_value_from_ui: function() {
var value = this.$input.val() || false;
@@ -1445,7 +1445,7 @@
this.datewidget.set_value(value);
},
get_value: function() {
- return this.datewidget.get_value();
+ return this.datewidget.get_value() || false;
},
update_dom: function() {
this._super.apply(this, arguments);
_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help : https://help.launchpad.net/ListHelp
