Review: Needs Fixing

I am a bit worried about all the changes you've done.  I am not sure you should 
change the behavior or procurement when MRP is not installed...

There is also a nasty bug in your code.  Specifically:
 - at line 237, project_id is assigned the id of an *analytic account* (the one 
of the sale order);
 - at line 249, project_id is supposed to be the id of a *project*.
Some of the code that you removed was necessary...

Please fix the latter and resubmit your proposal.

Raphael

-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-clean_yml_sales-hmo/+merge/84081
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openobject-addons/trunk-clean_yml_sales-hmo.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to