Review: Needs Fixing After another inspection, I found another problem in the diff:
69 + if product.supply_method <> 'produce': 70 + supplier = product.seller_id 71 + if supplier and user.company_id and user.company_id.partner_id: 72 + if supplier.id == user.company_id.partner_id.id: 73 + res = True 74 + res = False When the condition on line 69 is True, then res = False in all cases. This is not what the original code intended to do. Thanks, Raphael -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-clean_yml_sales-hmo/+merge/84081 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-clean_yml_sales-hmo. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
