I don't really care, but here goes * A bunch of doc-comments have been cut/pasted with the code referring types which don't exist in the library (or which provide wompletely incorrect behaviors)
* As far as I can see, Widget#destroy significantly reimplements the corresponding method in `ParentedMixin`, is there a reason? * `render_element` and `start` neither return the type they should (resp. String and Deferred) nor raise an exception, subtypes may call them expecting sensible behavior (as documented) even though they should not do so (since they don't have a sensible behavior). * Why the incompatibilities with Backbone's events? Makes it harder to switch between them: - Backbone uses (event, function, object) in on/off; this code uses (event, object, function) - on/off (with bind/unbind as legacy aliases) versus bind/unbind - Backbone triggers `change` on a `set`, and triggers both `change:key` (for each key) and a global `change` (so listeners can get general change notification and repaint the whole thing rather than have to enumerate and bind every single attribute on the provider). The signature of the change: event handler is also incompatible with backbone's. wouldn't it be better if the events system tried to match backbone's own as much as possible, since it's pretty heavily inspired? & strangely I don't see the documentation happen ever if this is merged as is. But whatever. -- https://code.launchpad.net/~openerp-dev/openerp-web/trunk-core-extraction-2-niv/+merge/94747 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openerp-web/trunk-core-extraction-2-niv. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
