Review: Needs Information Quick notes based on rapid scan, not a full review:
- please cleanup the use of dicts, read our guidelines. For example l.201 & l.202 are useless and redundant with l.200 of the patch. Use the same technique as line 200 for line 39-49, etc. Read how to use/copy/update dicts properly in our guidelines (like guidelines 1.3) http://doc.openerp.com/v6.0/contribute/15_guidelines/coding_guidelines_python.html#the-clone-and-update - it seems you have added explicit steps to send documents by email, but you did not remove the automatic email send by the EDI, so the partner will receive several emails instead? - you are using the first email template found for a model, this is not very robust. If users have multiple templates how do we know the right one will be picked (default ordering is not stable!)? It would be much better to try using always the proper template based on an XML ID (or use the first one found only if it is not found). Users can go and update it if they want. - as already commented on the server patch, forcing email composition wizard in HTML mode is nonsense if we don't have a wysiwyg component for users to edit HTML... Looks like we need another solution for the problem you were trying to solve. Perhaps the easiest is to automatically send the mail when the user clicks on the button, without opening any composition wizard. If they want to change the mail they can simply edit the template...? -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-wkf-improvements/+merge/99502 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-wkf-improvements. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
