Mohammed Shekha(Open ERP) has proposed merging
lp:~openerp-dev/openerp-web/6.1-opw-573860-msh into lp:openerp-web/6.1.
Requested reviews:
OpenERP Core Team (openerp)
For more details, see:
https://code.launchpad.net/~openerp-dev/openerp-web/6.1-opw-573860-msh/+merge/102630
Hello,
Fixed the issue of IE8 which doesn't allow us to add field for export.
Note:- this bug is specifically faced in IE8.
Demo :- Open any view in IE8 and try to export the data, here you can not add
the field, also when the dialog is loaded it will also give the type mismatch
error.
Reason:- IE8 doesn't support the syntax opt = new Option('',''), if try to get
opt.childNodes ypu will not get the TextNode.
Thanks.
--
https://code.launchpad.net/~openerp-dev/openerp-web/6.1-opw-573860-msh/+merge/102630
Your team OpenERP R&D Team is subscribed to branch
lp:~openerp-dev/openerp-web/6.1-opw-573860-msh.
=== modified file 'addons/web/static/src/js/data_export.js'
--- addons/web/static/src/js/data_export.js 2012-01-17 08:58:12 +0000
+++ addons/web/static/src/js/data_export.js 2012-04-19 06:00:27 +0000
@@ -64,6 +64,10 @@
var $fmts = this.$element.find('#export_format');
_(formats).each(function (format) {
var opt = new Option(format.label, format.tag);
+ //To fix IE8 Issue which doesn't support above syntax
+ if(!opt.childNodes.length){
+ $(opt).html(format.label);
+ }
if (format.error) {
opt.disabled = true;
opt.replaceChild(
@@ -348,7 +352,12 @@
var field_list = this.$element.find('#fields_list');
if (this.$element.find("#fields_list option[value='" + field_id + "']")
&& !this.$element.find("#fields_list option[value='" + field_id + "']").length) {
- field_list.append(new Option(string, field_id));
+ var opt = new Option(string, field_id);
+ //To fix IE8 Issue which doesn't support above syntax
+ if(!opt.childNodes.length){
+ $(opt).html(string);
+ }
+ field_list.append(opt);
}
},
get_fields: function() {
_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help : https://help.launchpad.net/ListHelp
