Review: Needs Fixing

I'm not sure I understand the bug.

Tentative reproduction:

* Go to Admin > Translation > Import translation
* Fill
* Click "Import"

<- the popup should close automatically here instead of reloading?

Because while I can reproduce this I get the exact same behavior with the patch 
(testing with Firefox 12).

Also, from a technical point of view reading 
https://developer.mozilla.org/en/DOM/window.content `window.content` looks like 
a Gecko extension for use in XUL and usually aliasing `window.top` in web 
pages. It is not available either in Webkit (Safari, Chrome) or in Opera 
(tested in both). I would suggest lifting the selection of `topWindow` to get 
the "global" environment and lifting an instance of jQuery from that **iif** 
that is the right solution: from some of the warnings I can see (one being the 
tentative reloading of translations) it would seem the issue is in the 
selection of output: this is getting back a content partial while maybe it 
should get the "full" content (with all JS files &al).
-- 
https://code.launchpad.net/~openerp-dev/openobject-client-web/6.0-opw-6164-xal/+merge/104531
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openobject-client-web/6.0-opw-6164-xal.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to