Review: Needs Information Haven't tested the value of the fix, but a few things look weird reading the diff:
* I'm pretty sure the first chunk is not going to work right if form.hidden_fields is None: it creates an empty list, puts the hidden field in there and promptly proceeds to forget about it. * In the second chunk, why use `dict.update(key=value)` instead of `dict[key] = value`? * Also not sure what the point is of testing both that the property exists and that it's equal to `'new'`, what would be the reason for `params.view_target == 'new'` not being enough on its own? -- https://code.launchpad.net/~openerp-dev/openobject-client-web/6.0-opw-16478-xal/+merge/104507 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-client-web/6.0-opw-16478-xal. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
