Review: Resubmit Hi,
> Haven't tested the value of the fix, but a few things look weird reading the > diff: > > * I'm pretty sure the first chunk is not going to work right if > form.hidden_fields is None: it creates an empty list, puts the hidden field in > there and promptly proceeds to forget about it. I've moved that part before "create_form" call, which is returning an openerp.widgets.form_view.ViewForm instance. So basically the hidden fields part are now handled directly into ViewForm.__init__(). > > * In the second chunk, why use `dict.update(key=value)` instead of `dict[key] > = value`? Fixed Cheers, Xavier -- https://code.launchpad.net/~openerp-dev/openobject-client-web/6.0-opw-16478-xal/+merge/104507 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-client-web/6.0-opw-16478-xal. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
