Review: Needs Fixing code read + test
The fix is local to the return stock picking wizard which makes it unlikely to
have unwanted side effects on the rest of openerp. I've tested it and the
original issue is indeed solved.
There are however two remaining issues which I could not see before the fix:
1. nothing prevents the user from returning more products than was shipped (it
just works). This is worsened by the need to click on the "save" floppy disk
icon when editing the quantities which is not very practical. So IMO this
safety check must be added.
2. it is not possible to perform 2 different returns on the same Out move
because the name of the new picking is hardcoded to '%s-return' % pick.name and
there is a unique index in the SQL table causing the following error:
Traceback (most recent call last):
File
"/home/afayolle/work/alpes_dev/openerp_buildout/src/server/openerp/sql_db.py",
line 212, in execute
res = self._obj.execute(query, params)
IntegrityError: duplicate key value violates unique constraint
"stock_picking_name_uniq"
DETAIL: Key (name, company_id)=(OUT/00076-return, 1) already exists.
--
https://code.launchpad.net/~openerp-dev/openobject-addons/6.1-opw-575526-pso/+merge/109142
Your team OpenERP R&D Team is subscribed to branch
lp:~openerp-dev/openobject-addons/6.1-opw-575526-pso.
_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help : https://help.launchpad.net/ListHelp
