Review: Needs Fixing Hi,
Alexandre, thank you for your careful review and testing of the proposed patch! I'm partially okay with the current patch. The logic for avoiding to consider upstream moves as previous returns looks okay, and the second part to allow multiple returns for the same picking looks fine too (albeit mixing bug patches), but the extra check on the quantity is too much. This is adding a hard limit on the returned quantity, and as a policy we tend to avoid putting hard limit on anything related to stock quantities, because these numbers can often contain temporary errors to which the system must always be tolerant. There may be customers in production who use this daily and would consider it a regression. BTW it is also out-of-scope for the bug report and for a stable release in any case. The policy for stable branches is: bugfixes only, lowest-risk possible, and no improvements, period. (Small improvements here and there are how we used to introduce a lot of regressions and had stable branches that were not very stable) I will merge the patch in 6.0 and 6.1 after removing the extra warning, so there is no need to submit an update. Thanks! -- https://code.launchpad.net/~openerp-dev/openobject-addons/6.1-opw-575526-pso/+merge/109142 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-addons/6.1-opw-575526-pso. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
