Review: Disapprove

> May be qweb preprocessor is not translating placeholders right now.

That is the issue indeed: the extraction script does not extract these 
attributes, and the registered preprocessor (somewhere in core) does not handle 
their translation.

> At my end it's working fine after this changes only.

No, it's not working for any acceptable value of working, new @placeholder 
attributes will fail to be translatable unless rewritten to this style, which 
has no reason to happen and is not any more acceptable than @title or @alt not 
being translatable on their own.
-- 
https://code.launchpad.net/~openerp-dev/openerp-web/trunk-placeholder-translatable/+merge/110311
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openerp-web/trunk-placeholder-translatable.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to