Review: Needs Fixing
>From reading it, I think on_breadcrumb_clicked is buggy, the breadcrumb
>removal is going to skip a bunch of breadcrumbs:
(a b c d e f g h)
* click "c", i=2
* continue, i=3 (note: the identity test could probably add an or'd condition
of `!item` to avoid performing a .data() call each time)
- remove breadcrumb,
(a b c e f g h)
* i=4
- remove breadcrumb
(a b c e g h)
* i=5
- remove breadcrumb
(a b c e g)
* i=6, i > breadcrumbs.length
we're left with e and g which should have been removed.
--
https://code.launchpad.net/~openerp-dev/openerp-web/trunk-breadcrumb-fme/+merge/113432
Your team OpenERP R&D Team is subscribed to branch
lp:~openerp-dev/openerp-web/trunk-breadcrumb-fme.
_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help : https://help.launchpad.net/ListHelp
