> > dunno, is it a problem ? > > I've had a case where it ended up badly: the inside would alter the object, > and the outside would use it to check the inside's alterations, which didn't > work (since it ended up comparing the object against itself). > > I'd find it safer.
fixed > > Because the loop serves a second purpose not possible to bundle in a _.find > > It's a purpose which doesn't work though ;) fixed > > It's my javascript snippets engine for loops, is it a problem ? > > Nah, it's just a question of habit, in most languages using C-style loop unary > incrementors tend to be used. fixed > > Do you want remove_breadcrumb to support both an index or an item object ? > > Nah. One or the other, whichever you prefer, but not both. fixed ... ho wait... > > If a widget should display more than one title (eg: view managers) then it > get_title should return an array of titles, show() will receive the index of > the title selected by the user. > > The weird part of that is that all "title sections" of a given item will > *still* link to the exact same thing. yes, it's the responsibility of show() callback to do appropriate stuff using the index it receives. Do you see there a possible bug or an implementation oddity ? During development I refactored 3 times and in one of version I used a 1 to 1 map between the breadcrumb title item and the item pushed in the array. This resulted in on_mode_switch nightmares and there was twice as much code. > > Because the only purpose of the breadcrumb is to expose a helper which > generate the title. > > Doesn't/couldn't it *display* the crumbs as well? Because it kinda does that > already, what with formatting titles. Well it could be done, but I warned Antony that it might be good to refactor the titles of the viewmanagers (independently of the breadcrumb) > > I first tough about making a widget out of it and detach/attach it trough > the different widgets title DOM zones, but after tough, the Widget class was > not designed to change it's $element every now and then. > > Technically that should be possible if the backbonify branch is merged (and > not buggy). But I'm not sure why you need to move it around. Because if the breadcrumb is a widget, it should be moved around the different widgets. The title zone in the DOM is not in the action manager DOM but in each widget pushed as breadcrumb, so when you hide one and show another, the breadcrumb should be attached to the last shown widget. -- https://code.launchpad.net/~openerp-dev/openerp-web/trunk-breadcrumb-fme/+merge/113432 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openerp-web/trunk-breadcrumb-fme. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
