Review: Needs Fixing

For the JSDoc:

    @param {null|Function} item.show callback triggered whenever the widget 
should be shown back

this should use the "optional" syntax instead of an alternative:

    @param {Function} [item.show] …

also no need to say "callback", if the type is Function it's probably a 
callback.

And the extended callbacks descriptions e.g.

    // If multiple titles are used, the index can be used in order
    // to define which item of the breadcrumb has been trigerred.

I think should be in the function doc, above the @param or something.
-- 
https://code.launchpad.net/~openerp-dev/openerp-web/trunk-breadcrumb-fme/+merge/113432
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openerp-web/trunk-breadcrumb-fme.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to