Review: Needs Fixing Hello,
A first code review: - in 'hr_expense.py': you should do the message_post in batch, no need to browse on ids just to call a method on obj.id - in 'crm_lead.py': what's the purpose of the override of '_get_subscription_data' ? -- when overriding a method, always add a comment to say why you are overriding -- please pay attention to your variable name (example: the result of a self.browse is a list of leads, not subtypes) - general remark: we are moving towards shorter sentences; so use '[..] <b>done</>" instead of '[..] <b>has been done</b>'. Best regards, Thibault. -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-mail-subtype-apa/+merge/136128 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-mail-subtype-apa. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : openerp-dev-gtk@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
