Review: Needs Fixing Hello,
The method about subscribing a record followers to another record appears several time (_subscribe_salesteam_followers_to_contract, _subscribe_salesteam_followers_to_lead, _subscribe_salesteam_followers_to_order, _subscribe_project_followers_to_task). It could be interesting to implement a more generic method in mail_thread and call it with correct parameters, instead of re-implementing several times the same method. This way we will avoid having duplicated code, and it will be easier to maintain or update for future code refactoring. Best regards, -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-mail-subtype-apa/+merge/136584 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-mail-subtype-apa. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : openerp-dev-gtk@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
