Review: Needs Fixing
* Not only are jQuery's .addClass(String), .removeClass(String) and .attr(args) 
chainable, *they can operate on jQuery element sets*. There is no reason to use 
an explicit iteration loop to just set the same classes and attributes on *all* 
the elements of a collection

* At the JS level, use boolean values for things like ``disabled`` (as well as 
for ``readonly``): .attr('disabled', true) and .attr('disabled', false)

* jQuery already has a pseudo-class for the selector "input, textarea, select, 
button": ":input" http://api.jquery.com/input-selector/ you should use that 
instead of doing it by hand.
-- 
https://code.launchpad.net/~openerp-dev/openobject-client-web/6.0-opw-4916-sma/+merge/55889
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openobject-client-web/6.0-opw-4916-sma.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-web
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-web
More help   : https://help.launchpad.net/ListHelp

Reply via email to