Hi Jozef,

Please see inline..

On Thu, Mar 16, 2017 at 2:20 AM, Jozef Bacigál <[email protected]>
wrote:

> Topology ID configurable (free to merge it)
>
> https://git.opendaylight.org/gerrit/#/c/48108/
>

​Added some comment on this patch.​

>
>
> Bundles (rebase ongoing today, if verify+1 free to merge it)
>
> https://git.opendaylight.org/gerrit/#/c/53385/1
>
​In my opinion we should defer the bundle changes for the nitrogen, it's
already M5 and these changes are huge.​

>
>
> Remove drop-test feature from He design
>
> <https://git.opendaylight.org/gerrit/#/c/53063/>
> ​​ <https://git.opendaylight.org/gerrit/#/c/53063/>
> https://git.opendaylight.org/gerrit/#/c/53063/
>
>
>
> Remove action cases from yang *(Luiz can you tell me why this is not
> verified by integration tests ?)*
>
> <https://git.opendaylight.org/gerrit/#/c/51946/>
> ​​ <https://git.opendaylight.org/gerrit/#/c/51946/>
> https://git.opendaylight.org/gerrit/#/c/51946/
>
>
​I added some comments to it as well.​

>
>
> Some checkstyle warnings (Free to merge it)
>
> <https://git.opendaylight.org/gerrit/#/c/52490/6>
> ​​ <https://git.opendaylight.org/gerrit/#/c/52490/6>
> https://git.opendaylight.org/gerrit/#/c/52490/6
>
> https://git.opendaylight.org/gerrit/#/c/52650/2
>
> https://git.opendaylight.org/gerrit/#/c/52652/2
>
​All merged, thanks shuva.​

> https://git.opendaylight.org/gerrit/#/c/52658/2
>
​Above patch ​requires check-style fixing.

https://git.opendaylight.org/gerrit/#/c/52755/2
>
​This patch already require check-style fixing​

>
>
> SplitConnectionLayer (I run openflowplugin all test, no sure about
> results) *Luiz can you check the result plz?*
>
> https://git.opendaylight.org/gerrit/#/c/53276/2
>
​Do these changes contains the changes that we were talking on the thread?​

>
>
> Those patches (CONNECTION LAYER) I do rebase long time so there are three
> possibillity:
>
>
>
> -          if no big issues we should merge it and if something went bad
> solve it as an issue/bug
>
> -          if issues we fix it and merge it after code freeze
>
> -          we move in next release
>
>
>
>
>
> Another question
>
>
>
> *Should we not mark He design as DEPRECATED in this release ? Because we
> never get rid of it.*
>
​I think we officially mentioned that He will be deprecated, do we want to
mark the code deprecated ? I don't see any point in that because there is
no API exposes by that code as such that we need to mark deprecated, isn't
it ?​

>
>
> Jozef
>
>
>



-- 
Thanks
Anil
_______________________________________________
openflowplugin-dev mailing list
[email protected]
https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev

Reply via email to