Thank you Anil Topology id – I will reply ☺
Bundles – I think it is huge, but will not change any core plugin implementation. Not touch anything at all, it is just addition, and if we merge it now, we got time to test it. Actions – I will check it and fix if I were wrong ☺ Drop test – I talked with Luis, confirmed me that can be removed Check-style will anyway continue because we got A LOT of warnings… a lot Connection – Yes and No, YES: I added EOS and I added not to set slave on the connection, waiting for master set and if not the we set slave NO: I couldn’t add disconnect direct in OF-java unless we change/move it. Deprecation – OK probably a HUGE wiki warning or weather or something, that we will remove it, otherwise nobody stop using it anyway… /we still talking about it but I got feeling no downstream project take it seriously ☺ / Jozef From: Anil Vishnoi [mailto:[email protected]] Sent: Friday, March 17, 2017 1:43 AM To: Jozef Bacigál <[email protected]> Cc: openflowplugin-dev <[email protected]>; Abhijit Kumbhare <[email protected]>; Luis Gomez Palacios <[email protected]>; Prasanna Huddar <[email protected]>; Shuva Jyoti Kar <[email protected]> Subject: Re: gentle reminder before code freeze Hi Jozef, Please see inline.. On Thu, Mar 16, 2017 at 2:20 AM, Jozef Bacigál <[email protected]<mailto:[email protected]>> wrote: Topology ID configurable (free to merge it) https://git.opendaylight.org/gerrit/#/c/48108/ Added some comment on this patch. Bundles (rebase ongoing today, if verify+1 free to merge it) https://git.opendaylight.org/gerrit/#/c/53385/1 In my opinion we should defer the bundle changes for the nitrogen, it's already M5 and these changes are huge. Remove drop-test feature from He design <https://git.opendaylight.org/gerrit/#/c/53063/> https://git.opendaylight.org/gerrit/#/c/53063/ Remove action cases from yang (Luiz can you tell me why this is not verified by integration tests ?) <https://git.opendaylight.org/gerrit/#/c/51946/> https://git.opendaylight.org/gerrit/#/c/51946/ I added some comments to it as well. Some checkstyle warnings (Free to merge it) <https://git.opendaylight.org/gerrit/#/c/52490/6> https://git.opendaylight.org/gerrit/#/c/52490/6 https://git.opendaylight.org/gerrit/#/c/52650/2 https://git.opendaylight.org/gerrit/#/c/52652/2 All merged, thanks shuva. https://git.opendaylight.org/gerrit/#/c/52658/2 Above patch requires check-style fixing. https://git.opendaylight.org/gerrit/#/c/52755/2 This patch already require check-style fixing SplitConnectionLayer (I run openflowplugin all test, no sure about results) Luiz can you check the result plz? https://git.opendaylight.org/gerrit/#/c/53276/2 Do these changes contains the changes that we were talking on the thread? Those patches (CONNECTION LAYER) I do rebase long time so there are three possibillity: - if no big issues we should merge it and if something went bad solve it as an issue/bug - if issues we fix it and merge it after code freeze - we move in next release Another question Should we not mark He design as DEPRECATED in this release ? Because we never get rid of it. I think we officially mentioned that He will be deprecated, do we want to mark the code deprecated ? I don't see any point in that because there is no API exposes by that code as such that we need to mark deprecated, isn't it ? Jozef -- Thanks Anil
_______________________________________________ openflowplugin-dev mailing list [email protected] https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev
