Hmm, so when it is working even without match, then my patch isnt necessary, so no need to create bug and I will abandon my patch.
________________________________________ Od: yann bourdeau [[email protected]] Odoslané: štvrtok, 13. apríla 2017 16:46 Komu: Tomáš Slušný Kópia: Miroslav Macko; [email protected]; [email protected]; Arun Paneri (NoviFlow) Predmet: Re: [openflowplugin-dev] Problem moving flow (FLOWMOD with experimenter action) from config datastore to operational stores (continued) HI Tomas, I tried this morning without a match field and without the fix. The flow got properly installed on the switch. Do you want me to still open the bug? The URI:http://localhost:8181/restconf/config/opendaylight-inventory:nodes/node/openflow:1/table/0/flow/1234 The VERB: PUT the Body: <?xml version="1.0" encoding="UTF-8" standalone="no"?> <flow xmlns="urn:opendaylight:flow:inventory"> <barrier>false</barrier> <cookie>10</cookie> <cookie_mask>10</cookie_mask> <flags>SEND_FLOW_REM</flags> <flow-name>FooXf1</flow-name> <hard-timeout>0</hard-timeout> <id>1234</id> <idle-timeout>0</idle-timeout> <installHw>false</installHw> <instructions> <instruction> <apply-actions> <action> <order>0</order> <nfx-action-set-payload-ip xmlns="urn:opendaylight:openflowplugin:extension:noviflow:action"> <payload_size>1</payload_size> <payload_offset>0</payload_offset> <hasmask>0</hasmask> <data>9</data> </nfx-action-set-payload-ip> </action> </apply-actions> <order>0</order> </instruction> </instructions> <priority>2</priority> <strict>false</strict> <table_id>0</table_id> </flow> The resulting flow on the switch: [TABLE 0] Total entries: 1 [FLOW_ID1] Timestamp = Sat Apr 15 02:51:07 2017 ofp_version = 4 ControllerGroup = 1 ControllerId = 1 Priority = 2 Idle_timeout = 0 Hard_timeout = 0 Packet_count = 0 Byte_count = 0 Cookie = a Send_flow_rem = true [MATCHFIELDS] all match [INSTRUCTIONS] [OFPIT_APPLY_ACTIONS] [ACTIONS] [OFPAT_EXPERIMENTER] [SET_IP_PAYLOAD_DATA] size = 1 offset = 0 hasmask = 0 value = 0x09 Le 12 avr. 2017 à 17:59, Tomáš Slušný <[email protected]<mailto:[email protected]>> a écrit : Also, can you please open bug for this also on BugZilla? Even if it will be solved by what Miroslav said, that issue with no match needs to be also solved, and so it should be tracked also on BugZilla. Thanks, Tomas ________________________________ Od: Miroslav Macko Odoslané: streda, 12. apríla 2017 18:43 Komu: yann bourdeau; Tomáš Slušný Kópia: [email protected]<mailto:[email protected]>; [email protected]<mailto:[email protected]>; Arun Paneri (NoviFlow) Predmet: Re: [openflowplugin-dev] Problem moving flow (FLOWMOD with experimenter action) from config datastore to operational stores (continued) Hello Yann, Please check if you have installed the feature odl-openflowplugin-app-forwardingrules-manager (alternatively odl-openflowplugin-app-forwardingrules-sync). Base on the logs that you have provided, it looks like it was not installed. Thanks, Miro ________________________________ Od: yann bourdeau <[email protected]<mailto:[email protected]>> Odoslané: streda, 12. apríla 2017 17:13:31 Komu: Tomáš Slušný Kópia: [email protected]<mailto:[email protected]>; [email protected]<mailto:[email protected]>; Arun Paneri (NoviFlow) Predmet: Re: [openflowplugin-dev] Problem moving flow (FLOWMOD with experimenter action) from config datastore to operational stores (continued) Hi Tomas, Here are the logs. Never mind the YANNB error log, it is log that I added to try to understand the code. Thanks again Le 12 avr. 2017 à 04:28, Tomáš Slušný <[email protected]<mailto:[email protected]>> a écrit : Hmm, that is weird, because it should work. Can you set org.opendaylight.openflowplugin.impl to DEBUG in karaf and send logs? ________________________________ Od: yann bourdeau <[email protected]<mailto:[email protected]>> Odoslané: utorok, 11. apríla 2017 20:15 Komu: Tomáš Slušný Kópia: Anil Vishnoi; [email protected]<mailto:[email protected]>; Arun Paneri (NoviFlow); [email protected]<mailto:[email protected]> Predmet: Re: [openflowplugin-dev] Problem moving flow (FLOWMOD with experimenter action) from config datastore to operational stores (continued) Hi Tomas, I tried with a match field (empty or not), it does not work. Here is my body of my REST request: <?xml version="1.0" encoding="UTF-8" standalone="no"?> <flow xmlns="urn:opendaylight:flow:inventory"> <barrier>false</barrier> <cookie>10</cookie> <cookie_mask>10</cookie_mask> <flags>SEND_FLOW_REM</flags> <flow-name>FooXf1</flow-name> <hard-timeout>0</hard-timeout> <id>1234</id> <idle-timeout>0</idle-timeout> <installHw>false</installHw> <match> <ipv4-destination>10.0.10.2/24</ipv4-destination> </match> <instructions> <instruction> <apply-actions> <action> <order>0</order> <nfx-action-set-payload-ip xmlns="urn:opendaylight:openflowplugin:extension:noviflow:action"> <payload_size>1</payload_size> <payload_offset>0</payload_offset> <hasmask>0</hasmask> <data>9</data> </nfx-action-set-payload-ip> </action> </apply-actions> <order>0</order> </instruction> </instructions> <priority>2</priority> <strict>false</strict> <table_id>2</table_id> </flow> Here is the flow in the configuration store (via a GET request): { "flow-node-inventory:table": [ { "id": 2, "flow": [ { "id": "1234", "hard-timeout": 0, "idle-timeout": 0, "match": { "ipv4-destination": "10.0.10.2/24" }, "flags": "SEND_FLOW_REM", "instructions": { "instruction": [ { "order": 0, "apply-actions": { "action": [ { "order": 0, "openflowplugin-extension-noviflow-action:nfx-action-set-payload-ip": { "payload_offset": 0, "data": [ 9 ], "payload_size": 1, "hasmask": 0 } } ] } } ] }, "priority": 2, "table_id": 2, "cookie_mask": 10, "cookie": 10, "installHw": false, "barrier": false, "strict": false, "flow-name": "FooXf1" } ] } ] } I have run Wireshark and I don’t see any flow mod request. Do you have any idea where I should be looking in the code for the problem? Thanks a lot, Le 11 avr. 2017 à 11:55, Tomáš Slušný <[email protected]<mailto:[email protected]>> a écrit : Hi yann, this was caused probably because you have <match/> missing. After moving to single layer serialization, I forgot to handle this case (what was working with old serialization method), so can you try to push your flow with empty match? And also, I created patch that should resolve this issue here: https://git.opendaylight.org/gerrit/#/c/54789/1 Regards, Tomas ________________________________ Od: yann bourdeau <[email protected]<mailto:[email protected]>> Odoslané: 11. apríla 2017 17:24 Komu: Anil Vishnoi Kópia: [email protected]<mailto:[email protected]>; Arun Paneri (NoviFlow); [email protected]<mailto:[email protected]> Predmet: Re: [openflowplugin-dev] Problem moving flow (FLOWMOD with experimenter action) from config datastore to operational stores (continued) Hi Anil, Here is the trace. As you can see, there is no flow created. Yann Bourdeau, M.Ing. Senior Software Developer 438-499-4607 [email protected]<mailto:[email protected]> Yann Bourdeau, M.Ing. Senior Software Developer 438-499-4607 [email protected]<mailto:[email protected]> Yann Bourdeau, M.Ing. Senior Software Developer 438-499-4607 [email protected]<mailto:[email protected]> _______________________________________________ openflowplugin-dev mailing list [email protected] https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev
