On Thu, May 25, 2017 at 6:16 PM, Vishal Thapar <[email protected]>
wrote:
> Hi Sridhar,
>
>
>
> If there is no change to pipeline why do you need to add support for newer
> actions? It does count as a pipeline change.
>
Maybe I was not clear. I meant to say that it would not impact IPv4
pipeline.
Basically, I was working closely with @Alon's team who started this
exercise (few months back) where they ran tempest IPv6 scenario tests in a
sandbox and reported the issues.
I've addressed multiple issues in Netvirt related to this use-case and the
final thing was support for ping6.
As you can see, all the tests invoke a common api [*], so the tests are
failing.
After we have the ping6 support in Netvirt, the status would be as follows
(for IPv6 tempest scenario tests).
- with networking-odl v1 driver all the tests would/should PASS.
- with networking-odl v2 driver the *multi_prefix* tests would fail and
the other tests would/should PASS. We have an open bug on
networking_odl-v2 driver for this issue [https://bugs.launchpad.net/
networking-odl/+bug/1676863]
[*]
https://github.com/openstack/tempest/blob/master/tempest/scenario/test_network_v6.py#L202
>
> Sam,
>
> Okay, I was [am?] a bit confused as from Sridhar’s mail it seemed like
> ping6 responder is a new feature coming in but from what you say it looks
> like existing ping responder should’ve worked for IPv6 also but is
> currently broken or was never working, correct? A netvirt patch could’ve
> made things clearer.
>
>
>
> Changes in Genius/OFP suggest it was never really working so something
> that got overlooked during IPv6 work that was done. In that case yes, we
> don’t really need a spec, but a bug is still required, even more so if we
> want this in Carbon-SR1.
>
>
>
> Regards,
>
> Vishal.
>
>
>
> *From:* Sam Hague [mailto:[email protected]]
> *Sent:* 25 May 2017 17:47
> *To:* Sridhar Gaddam <[email protected]>
> *Cc:* Vishal Thapar <[email protected]>; odl netvirt dev <
> [email protected]>; [email protected];
> [email protected]
> *Subject:* Re: [genius-dev] [openflowplugin-dev] Review request - Support
> for ping6 in ODL
>
>
>
> I don't think we need a spec as some functionality is broken now. The
> table 19 patch broke things so we need this fixed and we need tempest
> enabled to mitigate breaking it in the future. I could also see this
> following under the previous ipv6 specs as a minor overlooked item.
>
>
>
> On Thu, May 25, 2017 at 8:01 AM, Sridhar Gaddam <[email protected]>
> wrote:
>
> Hello Vishal,
>
>
>
> Its a single flow (which is supported on OVS2.5) similar to IPv4 ping and
> impacts only IPv6. There will not be any change/impact to IPv4 pipeline.
>
> Currently we are not running IPv6 tempest scenario tests because of this.
>
>
>
> As you know, we are adding new features in Netvirt and this is breaking
> IPv6 use-cases (fe., [1]). Sometimes we are not even aware that some
> existing IPv6 use-cases are broken.
>
> So, enabling tempest IPv6 scenario tests would help us to make sure that
> new changes are not creating issues to the existing IPv6 features.
>
> IMHO I don't feel that a spec is required for this use-case and would
> appreciate if we can get this in as soon as possible.
>
>
>
> [1] https://git.opendaylight.org/gerrit/#/c/57719/2
>
>
>
> Thanks,
>
> --Sridhar.
>
>
>
> On Thu, May 25, 2017 at 5:19 PM, Vishal Thapar <[email protected]>
> wrote:
>
> Hi Sridhar,
>
>
>
> I’d recommend raising a genius/netvirt spec for this. ICMPv6 responder is
> a new feature and impacts pipeline so should go proper design review et al.
>
>
>
> Regards,
>
> Vishal.
>
>
>
> *From:* [email protected] [mailto:
> [email protected]] *On Behalf Of *Sridhar
> Gaddam
> *Sent:* 25 May 2017 16:44
> *To:* [email protected]; openflowplugin-dev@lists.
> opendaylight.org; odl netvirt dev <[email protected]>
> *Subject:* [openflowplugin-dev] Review request - Support for ping6 in ODL
>
>
>
> Hello Genius/OpenflowPlugin teams,
>
>
>
> In order to enable tempest IPv6 scenario tests with ODL/Netvirt, ping6
> support for the Neutron router interfaces has to be supported.
>
> This is currently a missing gap, so we could not enable tempest IPv6
> scenario tests so far.
>
>
>
> I was looking at this use-case and figured out that we can support ping6
> similar to ping (in IPv4) by programming the necessary OVS flows that
> auto-respond to ping6 requests from the VMs.
>
>
>
> Following are the five dependent patches that are required to be merged in
> GENIUS and OpenflowPlugin for this use-case.
>
>
>
> I would appreciate if Openflowplugin and GENIUS teams take a look at the
> following dependent patches so that I can propose the necessary changes in
> Netvirt.
>
>
>
> *OpenflowPlugin patches:*
>
> 1. Add Nicira extension support for matching IPv6 Src/Dst -
> https://git.opendaylight.org/gerrit/#/c/56969/
>
> 2. Bug 8535: Fix IPv6 OXMHeader Mask issue - https://git.opendaylight.org/
> gerrit/#/c/57694/
>
>
>
> *GENIUS patches:*
>
> 1. Utility api to configure icmpv6 type - https://git.opendaylight.org/
> gerrit/#/c/57072/
>
> 2. Support for moving Src/Dest IPv6 addresses in NxRegMove action -
> https://git.opendaylight.org/gerrit/#/c/57027/
>
> 3. Support API that configures IPv6 address as sourceAddress -
> https://git.opendaylight.org/gerrit/#/c/57026/
>
>
>
> Thank you,
>
> --Sridhar.
>
>
>
>
>
>
>
>
> _______________________________________________
> genius-dev mailing list
> [email protected]
> https://lists.opendaylight.org/mailman/listinfo/genius-dev
>
>
>
_______________________________________________
openflowplugin-dev mailing list
[email protected]
https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev
