Sorry for jumping late on this feature. So looks like openflowplugin now is pulling infrautils features to consume the system.ready functionality. Now assume a scenario, where BGP project also moved to infrautils system.ready service and user install the bgp feature first and then openflowplugin features, will the system.ready service work in this case (openflowplugin will get notification)?
Looking at the system.ready state service, looks like it currently just looking at the bundles and if they are up in 5 minutes it notifies listener that system is ready. How is it different then the way karaf currently loads the bundles/features? Just trying to see the value-add here for relying on the system.ready service. Also looks like if for some reason some bundle does not come up in 5 minutes (for valid reasons) it will end up failing the system and openflowplugin won't start, which if you rely on just karaf loading, won't happen. is there any plan to further extend the check that system.ready does to ensure the system is ready? Because with the current integration it doesn't look like it's getting much from putting dependency on one more project. On Sun, Nov 26, 2017 at 10:44 PM, Vishal Thapar <[email protected]> wrote: > Humble request: Please don’t add dependency to Genius in OFP. > > > > Let us go with system ready for OFP as Muthu mentioned for now. Once we > get it in controller use it. > > > > Regards, > > Vishal. > > > > *From:* [email protected] [mailto: > [email protected]] *On Behalf Of *Faseela > K > *Sent:* 27 November 2017 12:06 > *To:* Muthukumaran K <[email protected]>; D Arunprakash < > [email protected]>; [email protected] > > *Cc:* [email protected]; Dayavanti Gopal Kamath < > [email protected]>; Tom Pantelis <[email protected]> > *Subject:* Re: [openflowplugin-dev] Proposing infrautils.ready > integration for openflowplugin > > > > Hi Arun, > > DATASTORE service patch was initially proposed in controller, and we > need to work on some more documentation stuff in infrautils to get this > there finally. Genius is just a temporary placeholder for the same, till > things get sorted out. > > Thanks, > > Faseela > > > > *From:* Muthukumaran K > *Sent:* Monday, November 27, 2017 11:47 AM > *To:* D Arunprakash <[email protected]>; Faseela K < > [email protected]>; [email protected] > *Cc:* [email protected]; Dayavanti Gopal Kamath < > [email protected]>; Tom Pantelis <[email protected]> > *Subject:* RE: [openflowplugin-dev] Proposing infrautils.ready > integration for openflowplugin > > > > IMO, we can start with system ready to begin with since OFP cannot have > Genius as runtime dependency > > > > Regards > > Muthu > > > > > > *From:* D Arunprakash > *Sent:* Monday, November 27, 2017 11:42 AM > *To:* Muthukumaran K; Faseela K; [email protected] > *Cc:* [email protected]; Dayavanti Gopal Kamath; Tom > Pantelis > *Subject:* RE: [openflowplugin-dev] Proposing infrautils.ready > integration for openflowplugin > > > > Hi Muthu/Faseela, > > The datastore service is registered from genius md-sal, if we install only > Openflowplugin features then we will have problem to obtain datastore > service status. > > > > For now, it’s not possible to check datastore service from Openflowplugin > using snd framework. > > > > We can open the southbound interface based on the system-ready from > infrautils. > > > > Regards, > > Arun > > *From:* [email protected] [ > mailto:[email protected] > <[email protected]>] *On Behalf Of > *Muthukumaran > K > *Sent:* Thursday, November 23, 2017 11:19 AM > *To:* Faseela K <[email protected]>; openflowplugin-dev@lists. > opendaylight.org > *Cc:* [email protected]; Dayavanti Gopal Kamath < > [email protected]>; Tom Pantelis <[email protected]> > *Subject:* Re: [openflowplugin-dev] Proposing infrautils.ready > integration for openflowplugin > > > > Yes. That would be the right approach and can simplify the check by > OFPlugin easier > > > > > > Regards > > Muthu > > > > > > *From:* Faseela K > *Sent:* Thursday, November 23, 2017 11:17 AM > *To:* Muthukumaran K; [email protected] > *Cc:* [email protected]; Sam Hague; Dayavanti Gopal > Kamath; Vivek Srivastava V; Tom Pantelis > *Subject:* RE: Proposing infrautils.ready integration for openflowplugin > > > > Thanks for the input Muthu! > > Diagstatus is already integrated to openflowplugin, and hence an > additional check can be made to see whether DATASTORE service is > operational when system is “ready”, before opening up the southbound > interfaces. > > > > Thanks, > > Faseela > > > > *From:* Muthukumaran K > *Sent:* Thursday, November 23, 2017 11:15 AM > *To:* Faseela K <[email protected]>; openflowplugin-dev@lists. > opendaylight.org > *Cc:* [email protected]; Sam Hague <[email protected]>; > Dayavanti Gopal Kamath <[email protected]>; Vivek > Srivastava V <[email protected]> > *Subject:* RE: Proposing infrautils.ready integration for openflowplugin > > > > It would be cleaner to include the datastore check apart from just ready > state. > > > > When the application-features get installed, corresponding yang models are > absorbed to build schema context incrementally. There is no absolute > telling when this completes depending upon how quick application features > get installed (Which in turn depend upon their dependency graph(s)). The > schemacontext present at the time of restoration will be used as it is for > validating and restoring data during scenarios like reboot. > > > > Though most of the apps get installed as part of boot features, it would > be better to include this exclusive check in addition to standard ready > check > > > > Hope we are all in sync > > > > Regards > > Muthu > > > > > > *From:* Faseela K > *Sent:* Tuesday, November 21, 2017 10:46 PM > *To:* [email protected] > *Cc:* [email protected]; Sam Hague; Dayavanti Gopal > Kamath; Vivek Srivastava V; Muthukumaran K > *Subject:* Proposing infrautils.ready integration for openflowplugin > > > > Hi Shuva/Arun > > As a follow up to diagstatus integration to openflowplugin, I would like > to propose the integration of infrautils.ready for openflowplugin. > > This way openflowplugin can open the southbound ports after all bundles > have come up properly. > > Also diagstatus can fetch the dynamic service status based on the > current southbound connection status as well as other criteria. > > This will help in many cases, including initial system bring up as well > as cluster reboot, as there is enough time for all applications to come up > gracefully before they start receiving southbound events. > > Please let us know your thoughts on the same. > > Thanks, > > Faseela > > _______________________________________________ > openflowplugin-dev mailing list > [email protected] > https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev > > -- Thanks Anil
_______________________________________________ openflowplugin-dev mailing list [email protected] https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev
