On Thu, Feb 15, 2018 at 4:40 PM, Vishal Thapar <[email protected]> wrote:
> I am working on netvirt patch but it will take a bit of time [say half an > hour?] as I have to update snapshots to pull Tom’s patch first. After that > genius and netvirt verification will further take up some time. > > > > So, I’d let you all make a call on waiting for netvirt and Genius aptches > vs reverting OFP for now and remerge it once netvirt and Genius patches are > ready, probably confirming with a multipatch. > I would say lets do the proper fix, but in an exception case like this of already broken build I personally would locally build and not wait for Jenkins +1 (and stupid waste of time distribution; sorry) - FYI that is what I just did with https://git.opendaylight.org/gerrit/#/c/68309/ - just force merged it after I locally confirmed that Faseela's change fixed the problem... if I were you, I would do the same for the netvirt change. > > > Regards, > > Vishal. > > > > *From:* [email protected] [mailto: > [email protected]] *On Behalf Of *Tom Pantelis > *Sent:* 15 February 2018 21:02 > *To:* Sam Hague <[email protected]> > *Cc:* [email protected]; openflowplugin-dev@lists. > opendaylight.org; R Srinivasan E <[email protected]>; release ( > [email protected]) <[email protected]> > *Subject:* Re: [genius-dev] [release] [openflowplugin-dev] genius builds > broken, due to openflowplugin lldp checkstyle changes > > > > > > > > On Thu, Feb 15, 2018 at 10:24 AM, Sam Hague <[email protected]> wrote: > > Ok, we are pushing patches to genius and netvirt to pick up the ofp > changes. > > > > > > Actually I was preparing an OFP patch to just revert the offending changes > and suppress CS violations but I'll hold off on that in lieu of genius > and netvirt patches. > > > > > > Going forward, I do see many more checkstyle patches in ofp. To avoid any > other breakages, please run the multipatch-build as a comment in the patch. > The first patch in the list is the ofp patch and needs to be first. > > > > multipatch-build:openflowplugin=36/67736/2,genius=changes/33/58233/15, > netvirt=15/68215/2 > > > > On Thu, Feb 15, 2018 at 10:12 AM, Faseela K <[email protected]> > wrote: > > Revert patch : https://git.opendaylight.org/gerrit/#/c/68308/ > > > > Thanks, > > Faseela > > > > *From:* [email protected] [mailto: > [email protected]] *On Behalf Of *Faseela > K > *Sent:* Thursday, February 15, 2018 8:34 PM > *To:* N Edwin Anthony <[email protected]>; > [email protected]; openflowplugin-dev@lists. > opendaylight.org; release ([email protected]) < > [email protected]> > *Cc:* R Srinivasan E <[email protected]> > *Subject:* Re: [openflowplugin-dev] genius builds broken, due to > openflowplugin lldp checkstyle changes > > > > +release > > > > Openflowplugin committers, > > > > Can we get the below patch reverted? > > > > Thanks, > > Faseela > > > > *From:* Faseela K > *Sent:* Thursday, February 15, 2018 6:03 PM > *To:* 'N Edwin Anthony' <[email protected]>; > [email protected]; openflowplugin-dev@lists. > opendaylight.org > *Cc:* R Srinivasan E <[email protected]> > *Subject:* RE: genius builds broken, mdsalutil-api is not building > > > > Looks like this patch in openflowplugin needs to be reverted. > > > > https://git.opendaylight.org/gerrit/#/c/67736/ > > > > Thanks, > > Faseela > > > > *From:* [email protected] [ > mailto:[email protected] > <[email protected]>] *On Behalf Of *N Edwin > Anthony > *Sent:* Thursday, February 15, 2018 6:00 PM > *To:* [email protected]; openflowplugin-dev@lists. > opendaylight.org > *Cc:* R Srinivasan E <[email protected]> > *Subject:* [genius-dev] genius builds broken, mdsalutil-api is not > building > > > > Hi All, > > Genius builds are failing because of the reason: > *[ERROR] Failed to execute goal > org.apache.maven.plugins:maven-compiler-plugin:3.7.0:compile > (default-compile) on project mdsalutil-api: Compilation failure: Compilation > failure:* > > *11:15:19* *[ERROR] > /w/workspace/genius-distribution-check-oxygen/genius/mdsalutil/mdsalutil-api/src/main/java/org/opendaylight/genius/mdsalutil/packet/IPv4.java:[157,36] > cannot find symbol* > > *11:15:19* *[ERROR] symbol: variable NumBitsInAByte* > > *11:15:19* *[ERROR] location: class > org.opendaylight.openflowplugin.libraries.liblldp.NetUtils* > > *11:15:19* *[ERROR] > /w/workspace/genius-distribution-check-oxygen/genius/mdsalutil/mdsalutil-api/src/main/java/org/opendaylight/genius/mdsalutil/packet/IPv4.java:[492,54] > cannot find symbol* > > *11:15:19* *[ERROR] symbol: variable NumBitsInAByte* > > *11:15:19* *[ERROR] location: class > org.opendaylight.openflowplugin.libraries.liblldp.NetUtils* > > *11:15:19* *[ERROR] > /w/workspace/genius-distribution-check-oxygen/genius/mdsalutil/mdsalutil-api/src/main/java/org/opendaylight/genius/mdsalutil/packet/IPv4.java:[518,65] > cannot find symbol* > > *11:15:19* *[ERROR] symbol: variable NumBitsInAByte* > > *11:15:19* *[ERROR] location: class > org.opendaylight.openflowplugin.libraries.liblldp.NetUtils* > > *11:15:19* *[ERROR] > /w/workspace/genius-distribution-check-oxygen/genius/mdsalutil/mdsalutil-api/src/main/java/org/opendaylight/genius/mdsalutil/packet/IPv4.java:[587,46] > cannot find symbol* > > *11:15:19* *[ERROR] symbol: variable NumBitsInAByte* > > *11:15:19* *[ERROR] location: class > org.opendaylight.openflowplugin.libraries.liblldp.NetUtils* > > *11:15:19* *[ERROR] > /w/workspace/genius-distribution-check-oxygen/genius/mdsalutil/mdsalutil-api/src/main/java/org/opendaylight/genius/mdsalutil/packet/ICMP.java:[185,58] > cannot find symbol* > > *11:15:19* *[ERROR] symbol: variable NumBitsInAByte* > > *11:15:19* *[ERROR] location: class > org.opendaylight.openflowplugin.libraries.liblldp.NetUtils* > > *11:15:19* *[ERROR] > /w/workspace/genius-distribution-check-oxygen/genius/mdsalutil/mdsalutil-api/src/main/java/org/opendaylight/genius/mdsalutil/packet/ICMP.java:[189,76] > cannot find symbol* > > *11:15:19* *[ERROR] symbol: variable NumBitsInAByte* > > *11:15:19* *[ERROR] location: class > org.opendaylight.openflowplugin.libraries.liblldp.NetUtils* > > *11:15:19* *[ERROR] > /w/workspace/genius-distribution-check-oxygen/genius/mdsalutil/mdsalutil-api/src/main/java/org/opendaylight/genius/mdsalutil/packet/ICMP.java:[226,79] > cannot find symbol* > > *11:15:19* *[ERROR] symbol: variable NumBitsInAByte* > > *11:15:19* *[ERROR] location: class > org.opendaylight.openflowplugin.libraries.liblldp.NetUtils* > > > are others facing similar issues ? > > https://jenkins.opendaylight.org/releng/job/genius- > distribution-check-oxygen/1210/console > > > Thank you, > > Edwin. > > > > > _______________________________________________ > release mailing list > [email protected] > https://lists.opendaylight.org/mailman/listinfo/release > > > > _______________________________________________ > genius-dev mailing list > [email protected] > https://lists.opendaylight.org/mailman/listinfo/genius-dev > >
_______________________________________________ openflowplugin-dev mailing list [email protected] https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev
