Sorry for the inconvenience guys. When you make lots of check-style changes or review them, sometime you can miss the public static final ;).
@Sam remaining style check changes are within openflowplugin code which i think non of the project consume directly, so they probably are safe to merge. Were you guys able to multi patch job? I am planning to merge other check style patches, so if you are facing the issues with multipatch job, please let me know. On Thu, Feb 15, 2018 at 9:20 AM, Vishal Thapar <[email protected]> wrote: > No problem Tom, all’s well that ends well. > > > > Netvirt merged: https://git.opendaylight.org/gerrit/#/c/68312/ > > > > Distribution check was still running, but since verification passed, > merged it. > > > > *From:* Tom Pantelis [mailto:[email protected]] > *Sent:* 15 February 2018 21:59 > *To:* Michael Vorburger <[email protected]> > *Cc:* Vishal Thapar <[email protected]>; Sam Hague < > [email protected]>; [email protected]; release ( > [email protected]) <[email protected]>; > [email protected]; R Srinivasan E < > [email protected]> > *Subject:* Re: [genius-dev] [release] [openflowplugin-dev] genius builds > broken, due to openflowplugin lldp checkstyle changes > > > > > > > > On Thu, Feb 15, 2018 at 11:24 AM, Michael Vorburger <[email protected]> > wrote: > > On Thu, Feb 15, 2018 at 4:47 PM, Michael Vorburger <[email protected]> > wrote: > > On Thu, Feb 15, 2018 at 4:40 PM, Vishal Thapar <[email protected]> > wrote: > > I am working on netvirt patch but it will take a bit of time [say half an > hour?] as I have to update snapshots to pull Tom’s patch first. After that > genius and netvirt verification will further take up some time. > > > > So, I’d let you all make a call on waiting for netvirt and Genius aptches > vs reverting OFP for now and remerge it once netvirt and Genius patches are > ready, probably confirming with a multipatch. > > > > I would say lets do the proper fix, but in an exception case like this of > already broken build I personally would locally build and not wait for > Jenkins +1 (and stupid waste of time distribution; sorry) - FYI that is > what I just did with https://git.opendaylight.org/gerrit/#/c/68309/ - > just force merged it after I locally confirmed that Faseela's change fixed > the problem... if I were you, I would do the same for the netvirt change. > > > > https://git.opendaylight.org/gerrit/#/c/68311/ fixes other :-( compilation > problems.. phew. > > > > > > Thanks man. Sorry about the inconvenience. I didn't realize anyone was > using the lib outside of OFP. > > > > _______________________________________________ > release mailing list > [email protected] > https://lists.opendaylight.org/mailman/listinfo/release > > -- Thanks Anil
_______________________________________________ openflowplugin-dev mailing list [email protected] https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev
