Thanks for the patch. This is merged now. On Tue, Apr 17, 2018 at 8:24 AM, Tim Rozet <[email protected]> wrote:
> I'm not an OFP committer or active contributor. CC'ing the list to see if > we can solicit some reviews: > https://git.opendaylight.org/gerrit/#/c/70802/ > > Tim Rozet > Red Hat SDN Team > > On Mon, Apr 16, 2018 at 10:31 PM, Moshe Levi <[email protected]> wrote: > >> Hi Tim, >> >> Is there any plan to merge the fix below? >> >> >> >> *From:* Moshe Levi >> *Sent:* Wednesday, April 11, 2018 9:58 PM >> *To:* Tim Rozet <[email protected]> >> *Cc:* Sam Hague <[email protected]>; [email protected] >> ight.org; Sulaiman Radwan <[email protected]>; Hamdy Khader < >> [email protected]>; Hasan Qunoo <[email protected]>; Waleed Musa < >> [email protected]> >> *Subject:* RE: [integration-dev] opendaylight is not listening on >> openflow config 6653 >> >> >> >> Sure, >> >> >> >> https://git.opendaylight.org/gerrit/#/c/70802/ >> >> >> >> *From:* Tim Rozet [mailto:[email protected] <[email protected]>] >> *Sent:* Wednesday, April 11, 2018 8:04 PM >> *To:* Moshe Levi <[email protected]> >> *Cc:* Sam Hague <[email protected]>; [email protected] >> ight.org; Sulaiman Radwan <[email protected]>; Hamdy Khader < >> [email protected]>; Hasan Qunoo <[email protected]>; Waleed Musa < >> [email protected]> >> *Subject:* Re: [integration-dev] opendaylight is not listening on >> openflow config 6653 >> >> >> >> OK cool. Are you going to push a fix to OFP? >> >> >> Tim Rozet >> >> Red Hat SDN Team >> >> >> >> On Tue, Apr 10, 2018 at 8:55 PM, Moshe Levi <[email protected]> wrote: >> >> Hi Tim, >> >> We checked it and just modifying the channel-outbound-queue-size solve >> the issue as well. So I guess the bug is in [1], which is missing the >> default value. >> >> >> >> [1] - https://github.com/opendaylight/openflowplugin/blob/9da2ccf7 >> 745c4ece86f84d355c9dfdd74b22832d/openflowjava/openflow- >> protocol-spi/src/main/yang/openflow-switch-connection-config.yang#L37 >> <https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fopendaylight%2Fopenflowplugin%2Fblob%2F9da2ccf7745c4ece86f84d355c9dfdd74b22832d%2Fopenflowjava%2Fopenflow-protocol-spi%2Fsrc%2Fmain%2Fyang%2Fopenflow-switch-connection-config.yang%23L37&data=02%7C01%7Cmoshele%40mellanox.com%7C25655dc4dd734e5edebb08d59fce45e0%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636590630643380227&sdata=iuHcOMX2y%2FGvWQUEpb%2BxIZZedlMacES9oKmhM14fY8o%3D&reserved=0> >> >> >> >> *From:* Tim Rozet [mailto:[email protected]] >> *Sent:* Tuesday, April 10, 2018 4:46 PM >> *To:* Moshe Levi <[email protected]> >> *Cc:* Sam Hague <[email protected]>; [email protected] >> ight.org; Sulaiman Radwan <[email protected]>; Hamdy Khader < >> [email protected]>; Hasan Qunoo <[email protected]>; Waleed Musa < >> [email protected]> >> >> >> *Subject:* Re: [integration-dev] opendaylight is not listening on >> openflow config 6653 >> >> >> >> Can you (or did you already) try with only modifying the >> channel-outbound-queue-size in the conf file, and leaving out the >> group-add-mod-enabled? >> >> >> Tim Rozet >> >> Red Hat SDN Team >> >> >> >> On Mon, Apr 9, 2018 at 5:29 PM, Moshe Levi <[email protected]> wrote: >> >> We are using thee default, so it without TLS. >> >> >> >> >> >> *From:* Tim Rozet [mailto:[email protected]] >> *Sent:* Monday, April 9, 2018 11:54 PM >> *To:* Sam Hague <[email protected]> >> *Cc:* Moshe Levi <[email protected]>; [email protected] >> ight.org; Sulaiman Radwan <[email protected]>; Hamdy Khader < >> [email protected]>; Hasan Qunoo <[email protected]>; Waleed Musa < >> [email protected]> >> *Subject:* Re: [integration-dev] opendaylight is not listening on >> openflow config 6653 >> >> >> >> Hi Moshe, >> >> For group-add-mod-enabled it looks like it is false by default in yang, >> so it shouldn't matter if it is missing from the config file right? >> >> https://github.com/opendaylight/openflowplugin/blob/9da2ccf7 >> 745c4ece86f84d355c9dfdd74b22832d/openflowjava/openflow- >> protocol-spi/src/main/yang/openflow-switch-connection-config.yang#L53 >> <https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fopendaylight%2Fopenflowplugin%2Fblob%2F9da2ccf7745c4ece86f84d355c9dfdd74b22832d%2Fopenflowjava%2Fopenflow-protocol-spi%2Fsrc%2Fmain%2Fyang%2Fopenflow-switch-connection-config.yang%23L53&data=02%7C01%7Cmoshele%40mellanox.com%7C826b2365b18c4fb8c54f08d59e5c0dc4%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636589040560860196&sdata=SpGDckPKh0Hve82w5rOQ6silzry6s9%2FHS9sGzAMxwEI%3D&reserved=0> >> >> >> >> For channel-outbound-queue-size, that looks like a bug in openflowplugin >> that it has no default: >> >> https://github.com/opendaylight/openflowplugin/blob/9da2ccf7 >> 745c4ece86f84d355c9dfdd74b22832d/openflowjava/openflow- >> protocol-spi/src/main/yang/openflow-switch-connection-config.yang#L37 >> <https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fopendaylight%2Fopenflowplugin%2Fblob%2F9da2ccf7745c4ece86f84d355c9dfdd74b22832d%2Fopenflowjava%2Fopenflow-protocol-spi%2Fsrc%2Fmain%2Fyang%2Fopenflow-switch-connection-config.yang%23L37&data=02%7C01%7Cmoshele%40mellanox.com%7C826b2365b18c4fb8c54f08d59e5c0dc4%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636589040560860196&sdata=YwPiMU%2FlqSz8%2FAwSJs5RHbGTQM659J1rtwEvPlu49Js%3D&reserved=0> >> >> >> >> We see that OVS connects OK via openflow in our setups with [1]. I >> wonder what is different in our setups. Are you using TLS? >> >> >> >> Thanks, >> >> >> Tim Rozet >> >> Red Hat SDN Team >> >> >> >> On Sat, Apr 7, 2018 at 7:21 AM, Sam Hague <[email protected]> wrote: >> >> Adding Tim >> >> >> >> On Sat, Apr 7, 2018, 2:38 AM Moshe Levi <[email protected]> wrote: >> >> Hi Guys, >> >> >> >> We ran into an issue with tripleo (queens branch) that after depoment the >> opendaylight is not listening to the openflow port 6653. >> >> >> >> This is because of the TLS change in [1]. It seem that the openflow >> connection config file requires additional options group-add-mod-enabled >> and channel-outbound-queue-size. I compared it to the the openflow >> connection config in our devstack setup which is working. >> >> I pushed a commit that fix the issue [2], but maybe there is a better way >> to fix this. For example instead of creating the file we can take the >> default file and just edit the required option to avoid such breaks in the >> future. >> >> We are not expect in puppet so we are not sure if that can be done. >> >> >> >> Please advise what it the proper fix for this issue. >> >> >> >> [1] - https://github.com/opendaylight/integration-packaging- >> puppet-opendaylight/blob/master/templates/default-openf >> low-connection-config.xml.erb >> <https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fopendaylight%2Fintegration-packaging-puppet-opendaylight%2Fblob%2Fmaster%2Ftemplates%2Fdefault-openflow-connection-config.xml.erb&data=02%7C01%7Cmoshele%40mellanox.com%7C826b2365b18c4fb8c54f08d59e5c0dc4%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636589040560860196&sdata=M2mPNrSBdH7wBxY36WBfYeu1ra%2Bwobu%2FX9Txs8cs16M%3D&reserved=0> >> >> [2] https://git.opendaylight.org/gerrit/#/c/70616/ >> <https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.opendaylight.org%2Fgerrit%2F%23%2Fc%2F70616%2F&data=02%7C01%7Cmoshele%40mellanox.com%7C826b2365b18c4fb8c54f08d59e5c0dc4%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636589040560860196&sdata=p7qbQSvi2FLyGpDwHmvb%2Fj3vNByYFrE9x6NdIxiE8Ew%3D&reserved=0> >> >> >> >> _______________________________________________ >> integration-dev mailing list >> [email protected] >> https://lists.opendaylight.org/mailman/listinfo/integration-dev >> <https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.opendaylight.org%2Fmailman%2Flistinfo%2Fintegration-dev&data=02%7C01%7Cmoshele%40mellanox.com%7C826b2365b18c4fb8c54f08d59e5c0dc4%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636589040560860196&sdata=3r5fj2wyRk4zwYSb3cWvISjtgKLM2KKk6xMlmZKp%2FG4%3D&reserved=0> >> >> >> >> >> >> >> > > > _______________________________________________ > openflowplugin-dev mailing list > [email protected] > https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev > > -- Thanks Anil
_______________________________________________ openflowplugin-dev mailing list [email protected] https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev
