With the revert, CSITs are running fine for genius and netvirt. Thanks, Faseela
From: Abhijit Kumbhare [mailto:[email protected]] Sent: Monday, April 23, 2018 8:47 PM To: Faseela K <[email protected]> Cc: Luis Gomez <[email protected]>; Release <[email protected]>; [email protected]; [email protected]; [email protected] Subject: Re: [release] [integration-dev] [openflowplugin-dev] IMPORTANT: Build breakage in openflowplugin due IP address NoZone changes So I assume this topic is closed - and no need to have today's TWS session on this? On Sun, Apr 22, 2018 at 8:52 PM, Faseela K <[email protected]<mailto:[email protected]>> wrote: From the subsequent mails from Robert and Anil, there is a proposal that the change will be enhanced to fix equals() to be backward compatible. +1 to that. Thanks, Faseela From: Abhijit Kumbhare [mailto:[email protected]<mailto:[email protected]>] Sent: Monday, April 23, 2018 3:05 AM To: Luis Gomez <[email protected]<mailto:[email protected]>> Cc: Faseela K <[email protected]<mailto:[email protected]>>; Release <[email protected]<mailto:[email protected]>>; [email protected]<mailto:[email protected]>; [email protected]<mailto:[email protected]>; [email protected]<mailto:[email protected]> Subject: Re: [release] [integration-dev] [openflowplugin-dev] IMPORTANT: Build breakage in openflowplugin due IP address NoZone changes +100. Couldn’t have said it better. Folks - please confirm the answers to Luis’s questions. On Sun, Apr 22, 2018 at 1:16 PM Luis Gomez <[email protected]<mailto:[email protected]>> wrote: I hope as a community we can learn some lessons from this breakage: - Upstream projects: please do not push changes breaking or changing API behavior without notice or weather item. If the impact is unintentional please revert quick to minimize downtime and confusion. - Downstream projects: please attend the TSC meetings (at least the Managed ones), so when a decision is made impacting you, you can agree or object but not complaint later. Now that patch has been reverted and weather is in place: - Is anybody still interested in driving this change? - If so any objection from any downstream project? BR/Luis On Apr 22, 2018, at 11:04 AM, Faseela K <[email protected]<mailto:[email protected]>> wrote: Here are the revert patches in lispflowmapping and bgpcep. https://git.opendaylight.org/gerrit/#/c/71187/ https://git.opendaylight.org/gerrit/#/c/71193/ However, FYI that Anil has removed his -1 on ofp patch, and a weather is already in place. Also genius and netvirt CSITs are passing with the ovsdb patch. In case we decide to merge those patches in, the above ones can be abandoned. Thanks, Faseela From: [email protected]<mailto:[email protected]> [mailto:[email protected]]On Behalf Of Tom Pantelis Sent: Sunday, April 22, 2018 4:37 AM To: Sam Hague <[email protected]<mailto:[email protected]>> Cc: [email protected]<mailto:[email protected]>; [email protected]<mailto:[email protected]>; [email protected]<mailto:[email protected]>; Release <[email protected]<mailto:[email protected]>> Subject: Re: [release] [openflowplugin-dev] IMPORTANT: Build breakage in openflowplugin due IP address NoZone changes On Sat, Apr 21, 2018 at 6:22 PM, Sam Hague <[email protected]<mailto:[email protected]>> wrote: Well, maybe we can keep the change.. I ran ovsdb [1] and netvirt csit [2] using the ovsdb patch Vishal had for the issue and they both look to have passed. NetVirt relies on ofp, ovsdb and genius so that seems to show things work. I ran this in the last couple hours using the ovsdb distro from yesterday which should have been before Tom reverted the patch. If someone could verify my comment that the artifacts used in the CSIT run truly do have the changes, then maybe we can keep this change. That's good that it passed. But folks were asking to revert so that's what I did. If someone wants to "unrevert" it and drive that and ensure there's no other breakages, that's fine. Thanks, Sam [1] https://jenkins.opendaylight.org/releng/job/ovsdb-patch-test-core-fluorine/16/ [2] https://jenkins.opendaylight.org/releng/job/netvirt-csit-1node-openstack-queens-gate-stateful-fluorine/236 On Sat, Apr 21, 2018 at 7:13 AM, Abhijit Kumbhare <[email protected]<mailto:[email protected]>> wrote: Thanks Robert. On Sat, Apr 21, 2018 at 5:27 AM, Robert Varga <[email protected]<mailto:[email protected]>> wrote: On 21/04/18 01:49, Robert Varga wrote: >> The weather process >> needed to have been followed - with the possibility for downstream >> projects to not accept the change for legitimate reasons. Please do so >> in the future. >> >> The most ideal solution as suggested by Luis below & initially agreed by >> Tom would have been to back out the change, discuss it completely (in a >> the TWS call) and go ahead with the decision after the TWS call. As it >> stands, and pointed by Tom, backing out the change looks to be a >> daunting task. Since that is the case, let us do the following: >> 0) Unblock the projects by whatever means - whether it is projects >> merging the changes to accommodate the original patch or reverting >> 1) Robert, please create the weather report with the existing change > Sorry for the delay, today has been exceptionally busy, I will file a > weather item tomorrow. > https://jira.opendaylight.org/browse/TSC-96 Regards, Robert _______________________________________________ openflowplugin-dev mailing list [email protected]<mailto:[email protected]> https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev _______________________________________________ release mailing list [email protected]<mailto:[email protected]> https://lists.opendaylight.org/mailman/listinfo/release _______________________________________________ integration-dev mailing list [email protected]<mailto:[email protected]> https://lists.opendaylight.org/mailman/listinfo/integration-dev _______________________________________________ release mailing list [email protected]<mailto:[email protected]> https://lists.opendaylight.org/mailman/listinfo/release
_______________________________________________ openflowplugin-dev mailing list [email protected] https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev
