On Wed, 2009-01-21 at 19:47 +0000, [email protected] wrote:
> Hello!
>
> I've created a feature request #2526862 for HPI-B.03.01 support with
> proposed code changes.
>
> https://sourceforge.net/tracker/index.php?func=detail&aid=2526862&group_id=71730&atid=532254
>
> Please review.
>
> Anton Pak
Hi Anton,
Good patch. I reviewed the patch and didn't find anything that stood out
for me. Could you please add more details to TODO items in the patch.
For example:
saHpiIntialize() has
// TODO implement more checks
// TODO implement
More detail on what is intended to go in here would be helpful. The same
comment applies to other TODOs. Otherwise, as far as I am concerned, you
can go ahead and commit the patch. Please keep in mind, I personally
don't have a way to test this patch, so myself and the rest of the
community will have to rely on you to test and make sure this new
functionality works. Could you please include a summary of the test
results of regression tests as well as any new tests you might have
written to test the new functionality.
Thanks again for the initiative to add B.03 features.
Thanks,
-- Shuah
------------------------------------------------------------------------------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________
Openhpi-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openhpi-devel
