The default path should definitely be an absolute path.  
With a relative path, 90% of the users will encounter the error.  
It could be a variable in the configure.in with AC_SUBST() to get around
the /etc vs. /usr/local/etc issue.

Andy

-----Original Message-----
From: Bishop, Michael (ISB Linux/Telco) [mailto:[email protected]] 
Sent: Wednesday, May 12, 2010 4:16 PM
To: 'Lars Wetzel'
Cc: [email protected]
Subject: Re: [Openhpi-devel] new simulator - cannot build RPMs 

Lars -

I think having the path of the simulation.data file in the new_simulator
stanza of the openhpi.conf file is okay.  And I agree this makes life a
little easier for the users if they have more than one simulation.data
file.  I can see your reasoning here.

However, as a default, I would suggest an absolute path (e.g.,
/etc/openhpi/simulation.data) - rather than a relative path - because
you do not know what directory a user will be in when he/she starts
openhpid.  I suspect a relative path will cause more confusion (as was
my experience) than an absolute path.

Does anyone else have an opinion about this?

--michael

Regards,
Michael Bishop
Enterprise Servers and Storage (ISB Linux/Telco)
Hewlett-Packard Company
3404 E. Harmony Rd.  Bldg. 5L, Post B7,  Mailstop 42
Fort Collins, CO  80528-9599
Phone: 970-898-4393
E-Mail: [email protected]


> -----Original Message-----
> From: Lars Wetzel [mailto:[email protected]]
> Sent: Wednesday, May 12, 2010 1:34 PM
> To: [email protected]; Bishop, Michael (ISB
> Linux/Telco)
> Subject: Re: [Openhpi-devel] new simulator - cannot build RPMs
>
>
> Hi Michael,
>
> you can configure the path and name of the simulation.data file in
> openhpi.conf:
> file = "etc/openhpi/simulation.data"
>
> Why I chose this solution:
> - it should be flexible, if the user has more than one
> simulation data file
> - I don't like to introduce a new environment variable for
> the simulator since
> the simulator is a plugin
> - the default is at the moment the relativ path from the
> openhpi - root
>
> Hope it works for you
>    Lars
>
> On Tuesday, 11. May 2010 23:12, Bishop, Michael (ISB
> Linux/Telco) wrote:
> > Lars -
> >
> > I can now build and install the RPMs - including your new
> simulator RPM.
> >
> > However, I noticed this problem when starting up openhpid:
> >
> > May 11 14:55:29 saf1-bl460-1-0 openhpid: ERROR:
> (new_sim_file.cpp, 135,
> > Configuration file 'etc/openhpi/simulation.data' could not
> be opened)
> >
> > I think you are assuming that the person who is starting
> openhpid is always
> > cd'ed to the / directory before issuing the start command.
> In my case, I
> > was cd'ed to /etc/openhpi when I attempted to start the
> daemon - and got
> > the above error.  Note that the path specified in the error
> message above
> > shows no leading /.
> >
> > Also, I should point out that the simulation.data file
> could easily end up
> > in /usr/local/etc/openhpi if the user set their prefix to
> /usr/local when
> > they performed the configure step of the build of openhpi.
> Your plugin
> > needs to respect the user's desire for where the simulation.data is
> > installed.  This problem is solved for the location of
> openhpi.conf - so it
> > should be solvable for your case too.
> >
> > If I start openhpid while I am cd'ed to the / directory, I
> can get the
> > simulator to run - and I will continue testing it - using
> this work-around.
> >  However, the above issues need to be addressed.
> >
> > --michael
> >
> > Regards,
> > Michael Bishop
> > Enterprise Servers and Storage (ISB Linux/Telco)
> > Hewlett-Packard Company
> > 3404 E. Harmony Rd.  Bldg. 5L, Post B7,  Mailstop 42
> > Fort Collins, CO  80528-9599
> > Phone: 970-898-4393
> > E-Mail: [email protected]
> >
> > > -----Original Message-----
> > > From: Bishop, Michael (ISB Linux/Telco)
> > > Sent: Tuesday, May 11, 2010 2:25 PM
> > > To: 'Lars Wetzel'; [email protected]
> > > Subject: Re: [Openhpi-devel] new simulator - cannot build RPMs
> > >
> > >
> > > Lars -
> > >
> > > Thanks for your attention to this problem.  I will now
> > > download your branch - and begin my testing of the new simulator.
> > >
> > > --michael
> > >
> > > Regards,
> > > Michael Bishop
> > > Enterprise Servers and Storage (ISB Linux/Telco)
> > > Hewlett-Packard Company
> > > 3404 E. Harmony Rd.  Bldg. 5L, Post B7,  Mailstop 42
> > > Fort Collins, CO  80528-9599
> > > Phone: 970-898-4393
> > > E-Mail: [email protected]
> > >
> > > > -----Original Message-----
> > > > From: Lars Wetzel [mailto:[email protected]]
> > > > Sent: Tuesday, May 11, 2010 12:35 PM
> > > > To: [email protected]
> > > > Cc: Bishop, Michael (ISB Linux/Telco)
> > > > Subject: Re: [Openhpi-devel] new simulator - cannot build RPMs
> > > >
> > > >
> > > > Hi Michael,
> > > >
> > > > I checked in a new version of openhpi.spec.in. Now it should
> > > > work. I could run
> > > > the rpm build successfully.
> > > >
> > > > Btw. I did it as you suggest: In openhpi.conf the
> > > > new_simulator is the last
> > > > entry and with comment signs. If you want to test the
> > > > new_simulator you have
> > > > to uncomment it first (and to comment the default simulator).
> > > > Default is
> > > > still the "old" simulator.
> > > >
> > > > Hope you can run it and the plugin can convince you
> > > > Regards
> > > >    Lars
> > > >
> > > >
> > > >
> > > > On Monday, 10. May 2010 22:49, Bishop, Michael (ISB
> > > >
> > > > Linux/Telco) wrote:
> > > > > Lars -
> > > > >
> > > > > As far as I know each file that is installed as part of an
> > > >
> > > > RPM has to have
> > > >
> > > > > its own entry in the rpm spec file that was used to
> build the RPM.
> > > > > openhpi.conf is already spoken for - so you cannot
> > > >
> > > > overwrite or replace
> > > >
> > > > > that file - when the new simulator rpm is installed.
> > > > >
> > > > > If you need to install simulation.data in /etc/openhpi -
> > > >
> > > > then you will have
> > > >
> > > > > to have a line describing this action somewhere in the spec
> > > >
> > > > file that is
> > > >
> > > > > used to generate your rpm file for the new simulator.  I
> > > >
> > > > would suggest
> > > >
> > > > > looking at some of the other plugins and see how they
> > > >
> > > > handle individual
> > > >
> > > > > files, and try to emulate that in your rpm spec file for
> > > >
> > > > the new simulator.
> > > >
> > > > > Also, if the new simulator requires changes to openhpi.conf
> > > >
> > > > in order for
> > > >
> > > > > the simulator to work - then the standard way of doing this
> > > >
> > > > is to have a
> > > >
> > > > > commented-out stanza in the openhpi.conf file.  Then later,
> > > >
> > > > a user could
> > > >
> > > > > modify (i.e., uncomment your stanza) openhpi.conf so that
> > > >
> > > > the new simulator
> > > >
> > > > > plugin is activated when OpenHPI is restarted.
> > > > >
> > > > > Hope this helps,
> > > > > --michael
> > > > >
> > > > > Regards,
> > > > > Michael Bishop
> > > > > Enterprise Servers and Storage (ISB Linux/Telco)
> > > > > Hewlett-Packard Company
> > > > > 3404 E. Harmony Rd.  Bldg. 5L, Post B7,  Mailstop 42
> > > > > Fort Collins, CO  80528-9599
> > > > > Phone: 970-898-4393
> > > > > E-Mail: [email protected]
> > > > >
> > > > > > -----Original Message-----
> > > > > > From: Lars Wetzel [mailto:[email protected]]
> > > > > > Sent: Monday, May 10, 2010 2:22 PM
> > > > > > To: [email protected]
> > > > > > Cc: Bishop, Michael (ISB Linux/Telco)
> > > > > > Subject: Re: [Openhpi-devel] new simulator - cannot
> build RPMs
> > > > > >
> > > > > >
> > > > > > Hi Michael,
> > > > > >
> > > > > > sorry, I didn't run make rpm in the past.
> > > > > > There were two issues with openhpi.spec.in. I repair it.
> > > > > >
> > > > > > But there is still an open issue:
> > > > > >
> > > > > > Checking for unpackaged
> > > > > > file(s): /usr/lib/rpm/check-files
> > > > > > /home/goofy/workspace/openhpi-newsimulator/rpm/INSTALL
> > > > > > error: Installed (but unpackaged) file(s) found:
> > > > > >    /etc/openhpi/simulation.data
> > > > > >
> > > > > > Maybe someone can give me a hint.
> > > > > > I thought the simulation file will be handled as
> > > > > > openhpi.conf, but it looks
> > > > > > like I miss something.
> > > > > >
> > > > > > Regards
> > > > > >    Lars
> > > > > >
> > > > > >
> > > > > >
> > > > > > On Monday, 10. May 2010 18:21, Bishop, Michael (ISB
> > > > > >
> > > > > > Linux/Telco) wrote:
> > > > > > > Lars -
> > > > > > >
> > > > > > > I attempted to build the new simulator branch today - but
> > > > > >
> > > > > > ran into issues
> > > > > >
> > > > > > > when I built the OpenHPI rpms.
> > > > > > >
> > > > > > > Attached is a log of the "make rpms" output.
> > > > > > >
> > > > > > > I normally, and would rather, test using rpms, as I can
> > > > > >
> > > > > > better control the
> > > > > >
> > > > > > > installation and removal of specific OpenHPI features.
> > > > > > >
> > > > > > > Please let me know if this is something you can fix
> > >
> > > right away.
> > >
> > > > > > > Regards,
> > > > > > > Michael Bishop
> > > > > > > Enterprise Servers and Storage (ISB Linux/Telco)
> > > > > > > Hewlett-Packard Company
> > > > > > > 3404 E. Harmony Rd.  Bldg. 5L, Post B7,  Mailstop 42
> > > > > > > Fort Collins, CO  80528-9599
> > > > > > > Phone: 970-898-4393
> > > > > > > E-Mail: [email protected]
> > > > > >
> > > > > > --
> > > > > > -------------------------------
> > > > > > Dipl. Wi.ing.
> > > > > > Lars Wetzel
> > > > > > Uttinger Str. 13
> > > > > > 86938 Schondorf a. Ammersee
> > > > > >
> > > > > > Tel.: 0179-2096845
> > > > > > Mail: [email protected]
> > > > > >
> > > > > > USt-IdNr.: DE181396006
> > > >
> > > > --------------------------------------------------------------
> > > > -------------
> > > >
> > > > >---
> > > > >
> > > > > _______________________________________________
> > > > > Openhpi-devel mailing list
> > > > > [email protected]
> > > > > https://lists.sourceforge.net/lists/listinfo/openhpi-devel
> > > >
> > > > --
> > > > -------------------------------
> > > > Dipl. Wi.ing.
> > > > Lars Wetzel
> > > > Uttinger Str. 13
> > > > 86938 Schondorf a. Ammersee
> > > >
> > > > Tel.: 0179-2096845
> > > > Mail: [email protected]
> > > >
> > > > USt-IdNr.: DE181396006
> > >
> > > --------------------------------------------------------------
> > > ----------------
> > >
> > > _______________________________________________
> > > Openhpi-devel mailing list
> > > [email protected]
> > > https://lists.sourceforge.net/lists/listinfo/openhpi-devel
> >
> >
> --------------------------------------------------------------
> -------------
> >---
> >
> > _______________________________________________
> > Openhpi-devel mailing list
> > [email protected]
> > https://lists.sourceforge.net/lists/listinfo/openhpi-devel
>
> --
> -------------------------------
> Dipl. Wi.ing.
> Lars Wetzel
> Uttinger Str. 13
> 86938 Schondorf a. Ammersee
>
> Tel.: 0179-2096845
> Mail: [email protected]
>
> USt-IdNr.: DE181396006
>

------------------------------------------------------------------------
------

_______________________________________________
Openhpi-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openhpi-devel

------------------------------------------------------------------------------

_______________________________________________
Openhpi-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openhpi-devel

Reply via email to