Michael/Lars, Great job.
If the NumAreas problem is fixed, I do not see any other problems pending. It may be worthwhile to bring in the changes from the trunk to new_simulator branch, build and test it once before merging it to the trunk. This will take care of the issues that may crop up in the common files that were changed on the dynamic_simulator branch. I am willing to test it once more after bringing in the changes to simulator, before the final merge. Let me know. Thanks Mohan On Mon, 2010-06-07 at 16:36 +0000, Bishop, Michael (ISB Linux/Telco) wrote: > Lars - > > I have confirmed that both issues are fixed in 7093. Running hpitest-3.1.1, > I'm still getting the same 8 failures as before out of 711 test cases. > > I am fine with having you merge your changes to top-of-trunk. However, I > would like for Mohan, and Uli to voice their opinion before you merge. > > I realize that most of the files associated with the dynamic_simulator are > new and should provide no merge issues. However, for files that are common > to the OpenHPI infrastructure - I recommend a very careful hand-merge to make > sure that you merge your changes, and any changes that were made subsequently > by other developers after you created your branch off the trunk. For > instance, Anton made some changes to the build structure - and you may > encounter some of his changes to the same common files you have changed. > After you merge, be sure to do a make, make rpm, and make dist prior to > commiting your merged changeset. > > Mohan, Uli? > > --michael > > Regards, > Michael Bishop > Enterprise Servers and Storage (ISB Linux/Telco) > Hewlett-Packard Company > 3404 E. Harmony Rd. Bldg. 5L, Post B7, Mailstop 42 > Fort Collins, CO 80528-9599 > Phone: 970-898-4393 > E-Mail: [email protected] > > > -----Original Message----- > > From: Lars Wetzel [mailto:[email protected]] > > Sent: Sunday, June 06, 2010 11:47 AM > > To: [email protected] > > Cc: Bishop, Michael (ISB Linux/Telco); [email protected] > > Subject: Re: [Openhpi-devel] New simulator testing > > > > > > Hi Michael and Mohan, > > > > sorry I forget it. Both is fixed. > > > > Regards > > Lars > > > > > > > > On Friday, 4. June 2010 23:33, Bishop, Michael (ISB > > Linux/Telco) wrote: > > > Lars - > > > > > > I downloaded your latest branch (7091) and ran testing > > (hpitest 3.1.1) on > > > the dynamic simulator. > > > > > > I'm getting 8 failures out of 711 test cases - using hpitest-3.1.1. > > > > > > A couple of comments: > > > > > > First - thanks for all the work. > > > > > > Second, in the openhpi.conf file - you still refer to the > > simulator as the > > > new_simulator in your comments for your stanza. Might want > > to change that. > > > > > > Secondly, it does not appear that the IDR area count issue > > has been fixed. > > > This is the issue that Mohan had described earlier. The > > area count and the > > > number of actual IDR areas should always match. > > > > > > If you start up your dynamic_simulator plugin, then run > > > /usr/bin/hpigensimdata and capture the output. > > > > > > The run the test: > > > > > > ./hpitest Inventory/saHpiIdrInfoGet/UpdateCounter > > > > > > Then run /usr/bin/hpigensimdata again, and compare the > > output to the first > > > run of hpigensimdata - you will see the discrepancy. In > > second output of > > > hpigensimdata, the area count is set at 2 - but the actual > > number of areas > > > present in the data file is only 1. > > > > > > /usr/bin/hpigensimdata > mdata1.txt > > > ./hpitest Inventory/saHpiIdrInfoGet/UpdateCounter > > > /usr/bin/hpigensimdata > mdata2.txt > > > diff mdata1.txt mdata2.txt > > > 1715c1715 > > > < UpdateCount=0 > > > --- > > > > > > > UpdateCount=2 > > > > > > 1717c1717 > > > < NumAreas=1 > > > --- > > > > > > > NumAreas=2 > > > > > > --michael > > > > > > Regards, > > > Michael Bishop > > > Enterprise Servers and Storage (ISB Linux/Telco) > > > Hewlett-Packard Company > > > 3404 E. Harmony Rd. Bldg. 5L, Post B7, Mailstop 42 > > > Fort Collins, CO 80528-9599 > > > Phone: 970-898-4393 > > > E-Mail: [email protected] > > ------------------------------------------------------------------------------ > ThinkGeek and WIRED's GeekDad team up for the Ultimate > GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the > lucky parental unit. See the prize list and enter to win: > http://p.sf.net/sfu/thinkgeek-promo > _______________________________________________ > Openhpi-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/openhpi-devel -- mo...@fc <[email protected]> ------------------------------------------------------------------------------ ThinkGeek and WIRED's GeekDad team up for the Ultimate GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the lucky parental unit. See the prize list and enter to win: http://p.sf.net/sfu/thinkgeek-promo _______________________________________________ Openhpi-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openhpi-devel
