Uli -
Thanks for submitting the patch. I'm on board with adding domain support - and
I agree it should be in the library. A couple of things:
1. You should test this change thoroughly before committing it by running
'make distcheck', the hpitest conformance suite, and the OpenHPI client
programs. I know it's a lot to ask - but if we don't do this work now - it's
get a lot harder and very time-consuming during the release process.
2. Also, there's a general policy in place that code files should not exceed
80 columns in length. You may want to check this prior to commit.
Thanks for the contribution!
--michael
-----Original Message-----
From: Kleber, Ulrich (NSN - DE/Munich) [mailto:[email protected]]
Sent: Friday, July 23, 2010 6:53 AM
To: [email protected]
Subject: [Openhpi-devel] Domain discovery
Hi,
I created a patch, that provides a DRT for the default domain (done by the
library).
A call of saHpiDrtEntryGet in a session to the default domain or
SAHPI_UNDEFINED_DOMAIN_ID
helps discover the domains.
The hpidomain client this way discovers the domains, as well as the hpi_shell
command domain.
Please note that different clients can have diffferent openhpiclient.conf files
and will see a different
set of domains. Therefore the implementation of this DRT of the default domain
really should be
part of the library.
Any comments?
I'll try to visit the chat room later today.
Cheers,
Uli
<<default-drt.patch>>
------------------------------------------------------------------------------
This SF.net email is sponsored by Sprint
What will you do first with EVO, the first 4G phone?
Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first
_______________________________________________
Openhpi-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openhpi-devel
