Uli, The hpidomain application looks very good for me. As for DRT patch I am still thinking over.
Anton Pak > Hi, > > I did some more testing with the domain patches. > - My configuration is 2 shelf ATCA, one shelf completely full with 16 > blades and 28 AMC, the other one only a few blades. > - I run hpitest-3.1.1 with 3 OpenHPI revisions: 2.15.0, rev-7130 and the > patched rev-7130. > - I also tested to modify the MaxOutstanding parameter for the > ipmidirect plugin. > > The attached excel compares the results. > - with my patch all domain tests PASS. > - hpitest really uses domain discovery. In one case, > WatchdogTimer/saHpiWatchdogTimerGet/Countdown had an error using a > resource in a non-default domain. But it didn't happen every time. So > this needs to be checked. The positive part of this is that 10 test > cases moved from NOT SUPPORTED to PASS, because the test suite was able > to find resources in a non-default domain. > - I needed to exclude the reset test cases and also two other test > cases, which had caused a "non-recoverable timeout". > - A few other cases I still need to investigate, but I suspect some > sporadic problem there. > - With MaxOutstanding set to 20, everything looks identical except one > test case: Sensor/saHpiSensorReadingGet/GetAndVerify. I'll try to find > the cause for that before we add this option to the example conf file. > - We need to investigate the over 70 test cases which don't PASS in > 2.15.0. > > I corrected two small things in my patch (a \n in the output of > hpidomain.c and a corrected error code in drtentryget) and did the > formal stuff: > - all changes now don't exceed 80 columns in length (existing code does > and I didn't change that). > - the make distcheck works (after setting --disable-ipmi manually) > The attached .tgz archive contains the new patch and the new > hpidomain.c. > > Beside our discussion in the chat room I didn't get other feedback to > the changes. Shall I commit the patch now to the main trunk? > (I will add then also a man entry for hpidomain). > > Cheers, > Uli > > > > > > ________________________________ > > From: ext Bishop, Michael (ISB Linux/Telco) > [mailto:[email protected]] > Sent: Friday, July 23, 2010 5:04 PM > To: '[email protected]' > Subject: Re: [Openhpi-devel] Domain discovery > > > Uli - > > Thanks for submitting the patch. I'm on board with adding > domain support - and I agree it should be in the library. A couple of > things: > > 1. You should test this change thoroughly before committing it > by running 'make distcheck', the hpitest conformance suite, and the > OpenHPI client programs. I know it's a lot to ask - but if we don't do > this work now - it's get a lot harder and very time-consuming during the > release process. > > 2. Also, there's a general policy in place that code files > should not exceed 80 columns in length. You may want to check this > prior to commit. > > Thanks for the contribution! > > --michael > > > > -----Original Message----- > From: Kleber, Ulrich (NSN - DE/Munich) > [mailto:[email protected]] > Sent: Friday, July 23, 2010 6:53 AM > To: [email protected] > Subject: [Openhpi-devel] Domain discovery > > > > Hi, > I created a patch, that provides a DRT for the default > domain (done by the library). > A call of saHpiDrtEntryGet in a session to the default > domain or SAHPI_UNDEFINED_DOMAIN_ID > helps discover the domains. > The hpidomain client this way discovers the domains, as > well as the hpi_shell command domain. > Please note that different clients can have diffferent > openhpiclient.conf files and will see a different > set of domains. Therefore the implementation of this DRT > of the default domain really should be > part of the library. > Any comments? > I'll try to visit the chat room later today. > Cheers, > Uli > > <<default-drt.patch>> > > ------------------------------------------------------------------------------ > The Palm PDK Hot Apps Program offers developers who use the > Plug-In Development Kit to bring their C/C++ apps to Palm for a share > of $1 Million in cash or HP Products. Visit us here for more details: > http://p.sf.net/sfu/dev2dev-palm_______________________________________________ > Openhpi-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/openhpi-devel > ------------------------------------------------------------------------------ The Palm PDK Hot Apps Program offers developers who use the Plug-In Development Kit to bring their C/C++ apps to Palm for a share of $1 Million in cash or HP Products. Visit us here for more details: http://p.sf.net/sfu/dev2dev-palm _______________________________________________ Openhpi-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openhpi-devel
